Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] backport test PRs #10499, #10488, #10510 and #10518 #10541

Merged
merged 4 commits into from
Mar 5, 2024
Merged

[tests-only][full-ci] backport test PRs #10499, #10488, #10510 and #10518 #10541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a810b07
share with custom perm (#10499)
ScharfViktor Feb 21, 2024
bbf16e7
[tests-only] added e2e test to receive two shares with same name (#10…
PrajwolAmatya Feb 21, 2024
8e07219
delete repeated upload tests (#10510)
ScharfViktor Feb 23, 2024
91622b1
[test-only] rewrite copy/move tests (#10518)
ScharfViktor Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions .drone.star
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,6 @@ config = {
"webUIPreview",
"webUILogin",
],
"oCISSharingBasic": [
"webUISharingAcceptShares",
],
"oCISFiles1": [
"webUICreateFilesFolders",
"webUIDeleteFilesFolders",
Expand Down Expand Up @@ -138,14 +135,6 @@ config = {
],
"oCISSharingPerm1": [
"webUISharingPermissionsUsers",
"webUISharingFolderPermissionsGroups",
],
"oCISSharingPerm2": [
"webUISharingFilePermissionsGroups",
"webUISharingFilePermissionMultipleUsers",
"webUISharingFolderPermissionMultipleUsers",
"webUISharingFolderAdvancedPermissionMultipleUsers",
"webUISharingFolderAdvancedPermissionsGroups",
],
"oCISSharingPublic1": [
"webUISharingPublicBasic",
Expand All @@ -164,7 +153,6 @@ config = {
"webUITrashbinDelete",
"webUITrashbinFilesFolders",
"webUITrashbinRestore",
"webUIUserJourney",
],
},
"extraEnvironment": {
Expand Down Expand Up @@ -197,12 +185,6 @@ basicTestSuites = [
"webUIRenameFolders",
"webUISharingAcceptShares",
"webUISharingAutocompletion",
"webUISharingFilePermissionMultipleUsers",
"webUISharingFilePermissionsGroups",
"webUISharingFolderAdvancedPermissionMultipleUsers",
"webUISharingFolderAdvancedPermissionsGroups",
"webUISharingFolderPermissionMultipleUsers",
"webUISharingFolderPermissionsGroups",
"webUISharingInternalGroups",
"webUISharingInternalGroupsEdgeCases",
"webUISharingInternalGroupsSharingIndicator",
Expand All @@ -220,10 +202,6 @@ basicTestSuites = [
"webUIUpload",
]

ocisSpecificTestSuites = [
"webUIUserJourney",
]

# minio mc environment variables
minio_mc_environment = {
"CACHE_BUCKET": {
Expand Down Expand Up @@ -272,8 +250,6 @@ def checkTestSuites():
if (test["type"] == FULL):
expected += basicTestSuites

expected += ocisSpecificTestSuites

if (sorted(suites) != sorted(expected)):
print("Error: Suites dont match " + testGroupName)
print(Diff(sorted(suites), sorted(expected)))
Expand Down
10 changes: 1 addition & 9 deletions tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ Other free text and markdown formatting can be used elsewhere in the document if

- [webUITrashbinRestore/trashbinRestore.feature:176](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L176)

### [Saving public share is not possible](https://github.com/owncloud/web/issues/5321)

- [webUISharingPublicManagement/shareByPublicLink.feature:24](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicManagement/shareByPublicLink.feature#L24)

### [empty subfolder inside a folder to be uploaded is not created on the server](https://github.com/owncloud/web/issues/6348)

- [webUIUpload/upload.feature:43](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L43)

### [PROPFIND to sub-folder of a shared resources with same name gives 404](https://github.com/owncloud/ocis/issues/3859)

- [webUISharingAcceptShares/acceptShares.feature:73](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L73)
- [webUIUpload/upload.feature:36](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L36)
142 changes: 0 additions & 142 deletions tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,38 +6,6 @@ Feature: deleting files and folders
Background:
Given user "Alice" has been created with default attributes and without skeleton files in the server

@smokeTest @ocisSmokeTest @disablePreviews
Scenario: Delete files & folders one by one and check its existence after page reload
Given user "Alice" has created folder "simple-empty-folder" in the server
And user "Alice" has created folder "simple-folder" in the server
And user "Alice" has created file "lorem.txt" in the server
And user "Alice" has created file "lorem-big.txt" in the server
And user "Alice" has created folder "strängé नेपाली folder" in the server
And user "Alice" has created file "strängé filename (duplicate #2 &).txt" in the server
And user "Alice" has created file "sample,1.txt" in the server
And user "Alice" has created folder "Sample,Folder,With,Comma" in the server
And user "Alice" has logged in using the webUI
When the user deletes the following elements using the webUI
| name |
| simple-folder |
| lorem.txt |
| strängé नेपाली folder |
| strängé filename (duplicate #2 &).txt |
| sample,1.txt |
| Sample,Folder,With,Comma |
Then as "Alice" folder "simple-folder" should not exist in the server
And as "Alice" file "lorem.txt" should not exist in the server
And as "Alice" folder "strängé नेपाली folder" should not exist in the server
And as "Alice" file "strängé filename (duplicate #2 &).txt" should not exist in the server
And as "Alice" file "sample,1.txt" should not exist in the server
And as "Alice" folder "Sample,Folder,With,Comma" should not exist in the server
And no message should be displayed on the webUI
And the deleted elements should not be listed on the webUI
But folder "simple-empty-folder" should be listed on the webUI
And file "lorem-big.txt" should be listed on the webUI
And file "strängé नेपाली folder" should not be listed on the webUI
But the deleted elements should not be listed on the webUI after a page reload


Scenario Outline: Delete a file with problematic characters
Given user "Alice" has created file <file_name> in the server
Expand All @@ -54,61 +22,6 @@ Feature: deleting files and folders
| "&and#hash" |


@ocis-reva-issue-106 @ocis-reve-issue-442 @skipOnOC10 @issue-4582
Scenario: Delete all except for a few files at once
Given user "Alice" has uploaded file "data.zip" to "data.zip" in the server
And user "Alice" has created file "lorem.txt" in the server
And user "Alice" has created file "fileToDelete.txt" in the server
And user "Alice" has created folder "folderToDelete" in the server
And user "Alice" has created folder "simple-folder" in the server
And user "Alice" has logged in using the webUI
When the user marks all files for batch action using the webUI
And the user unmarks these files for batch action using the webUI
| name |
| lorem.txt |
| simple-folder |
And the user batch deletes the marked files using the webUI
Then as "Alice" file "lorem.txt" should exist in the server
And as "Alice" folder "simple-folder" should exist in the server
And folder "simple-folder" should be listed on the webUI
And file "lorem.txt" should be listed on the webUI
But as "Alice" file "data.zip" should not exist in the server
And as "Alice" file "fileToDelete.txt" should not exist in the server
And as "Alice" folder "folderToDelete" should not exist in the server
And file "data.zip" should not be listed on the webUI
And the count of files and folders shown on the webUI should be 2
And no message should be displayed on the webUI


Scenario: Delete the last file in a folder
Given user "Alice" has created file "zzzz-must-be-last-file-in-folder.txt" in the server
And user "Alice" has logged in using the webUI
When the user deletes file "zzzz-must-be-last-file-in-folder.txt" using the webUI
Then as "Alice" file "zzzz-must-be-last-file-in-folder.txt" should not exist in the server
And file "zzzz-must-be-last-file-in-folder.txt" should not be listed on the webUI
And no message should be displayed on the webUI


Scenario: delete a file on a public share
Given user "Alice" has created folder "simple-folder" in the server
And user "Alice" has created file "simple-folder/lorem.txt" in the server
And user "Alice" has created folder "simple-folder/simple-empty-folder" in the server
And user "Alice" has created folder "simple-folder/strängé filename (duplicate #2 &).txt" in the server
And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user deletes the following elements using the webUI
| name |
| simple-empty-folder |
| lorem.txt |
| strängé filename (duplicate #2 &).txt |
Then as "Alice" file "simple-folder/lorem.txt" should not exist in the server
And as "Alice" folder "simple-folder/simple-empty-folder" should not exist in the server
And as "Alice" file "simple-folder/strängé filename (duplicate #2 &).txt" should not exist in the server
And the deleted elements should not be listed on the webUI
And no message should be displayed on the webUI
And the deleted elements should not be listed on the webUI after a page reload


Scenario: delete a file on a public share with problematic characters
Given user "Alice" has created file "lorem.txt" in the server
And user "Alice" has created folder "simple-folder" in the server
Expand Down Expand Up @@ -142,61 +55,6 @@ Feature: deleting files and folders
| question? |
| &and#hash |

@issue-4582
Scenario: Delete multiple files at once on a public share
Given user "Alice" has created folder "simple-folder" in the server
And user "Alice" has created file "simple-folder/data.zip" in the server
And user "Alice" has created file "simple-folder/lorem.txt" in the server
And user "Alice" has created file "simple-folder/simple-empty-folder" in the server
And user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions in the server
When the public uses the webUI to access the last public link created by user "Alice" in a new session
And the user batch deletes these files using the webUI
| name |
| data.zip |
| lorem.txt |
| simple-empty-folder |
Then as "Alice" file "simple-folder/data.zip" should not exist in the server
And as "Alice" file "simple-folder/lorem.txt" should not exist in the server
And as "Alice" folder "simple-folder/simple-empty-folder" should not exist in the server
And the deleted elements should not be listed on the webUI
And the deleted elements should not be listed on the webUI after a page reload

@issue-5435
Scenario: Delete a file and folder from shared with me page
Given user "Brian" has been created with default attributes and without skeleton files in the server
And user "Brian" has created folder "simple-folder" in the server
And user "Brian" has created file "lorem.txt" in the server
And user "Brian" has shared folder "simple-folder" with user "Alice" in the server
And user "Brian" has shared file "lorem.txt" with user "Alice" in the server
And user "Alice" has logged in using the webUI
And the user has browsed to the shared-with-me page
When the user unshares folder "simple-folder" using the webUI
And the user unshares file "lorem.txt" using the webUI
Then as "Alice" folder "simple-folder" should not exist in the server
And as "Alice" file "lorem.txt" should not exist in the server
And no message should be displayed on the webUI


Scenario: Try to delete file and folder that used to exist but does not anymore
Given user "Alice" has created folder "simple-folder" in the server
And user "Alice" has created file "lorem.txt" in the server
# user logs in first and deletes the files/folders using the API requests (demanded by the scenario)
# so that the steps are organized as follows
And user "Alice" has logged in using the webUI
And the following files have been deleted by user "Alice" in the server
| name |
| lorem.txt |
| simple-folder |
When the user deletes file "lorem.txt" using the webUI
Then the "error" message with header 'Failed to delete "lorem.txt"' should be displayed on the webUI
When the user clears all error message from the webUI
And the user deletes folder "simple-folder" using the webUI
Then the "error" message with header 'Failed to delete "simple-folder"' should be displayed on the webUI
When the user reloads the current page of the webUI
Then file "lorem.txt" should not be listed on the webUI
And folder "simple-folder" should not be listed on the webUI
And as "Alice" file "lorem.txt" should not exist in the server
And as "Alice" folder "simple-folder" should not exist in the server


Scenario: Delete folder with dot in the name
Expand Down
67 changes: 0 additions & 67 deletions tests/acceptance/features/webUIFilesCopy/copy.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,52 +7,6 @@ Feature: copy files and folders
Given the administrator has set the default folder for received shares to "Shares" in the server
And user "Alice" has been created with default attributes and without skeleton files in the server

@smokeTest @ocisSmokeTest @skipOnIphoneResolution
Scenario: copy a file and a folder into a folder
Given user "Alice" has uploaded file "data.zip" to "data.zip" in the server
And user "Alice" has created folder "simple-empty-folder" in the server
And user "Alice" has created folder "simple-folder" in the server
And user "Alice" has created folder "strängé नेपाली folder empty" in the server
And user "Alice" has logged in using the webUI
And the user reloads the current page of the webUI
When the user copies file "data.zip" into folder "simple-empty-folder" using the webUI
Then breadcrumb for folder "simple-empty-folder" should be displayed on the webUI
And file "data.zip" should be listed on the webUI
When the user browses to the files page
And the user copies folder "simple-folder" into folder "strängé नेपाली folder empty" using the webUI
Then breadcrumb for folder "strängé नेपाली folder empty" should be displayed on the webUI
And folder "simple-folder" should be listed on the webUI


Scenario: copy a file into a folder where a file with the same name already exists
Given user "Alice" has created file "strängé filename (duplicate #2 &).txt" in the server
And user "Alice" has created folder "strängé नेपाली folder" in the server
And user "Alice" has created file "strängé नेपाली folder/strängé filename (duplicate #2 &).txt" in the server
And user "Alice" has logged in using the webUI
And the user has browsed to the personal page
When the user tries to copy file "strängé filename (duplicate #2 &).txt" into folder "strängé नेपाली folder" using the webUI
Then the "modal error" message with header 'File with name "strängé filename (duplicate #2 &).txt" already exists.' should be displayed on the webUI

@smokeTest @ocisSmokeTest @skipOnIphoneResolution
Scenario: Copy multiple files at once
Given user "Alice" has uploaded file "data.zip" to "data.zip" in the server
And user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server
And user "Alice" has uploaded file "new-data.zip" to "testapp.zip" in the server
And user "Alice" has created folder "simple-empty-folder" in the server
And user "Alice" has logged in using the webUI
And the user has reloaded the current page of the webUI
When the user batch copies these files into folder "simple-empty-folder" using the webUI
| file_name |
| data.zip |
| lorem.txt |
| testapp.zip |
Then breadcrumb for folder "simple-empty-folder" should be displayed on the webUI
And the following files should be listed on the webUI
| file_name |
| data.zip |
| lorem.txt |
| testapp.zip |


Scenario Outline: copy a file into a folder (problematic characters)
Given user "Alice" has uploaded file "lorem.txt" to "lorem.txt" in the server
Expand Down Expand Up @@ -83,24 +37,3 @@ Feature: copy files and folders
And file "data.zip" should be listed on the webUI
And as "Alice" file "simple-folder/simple-empty-folder/data.zip" should exist in the server
And as "Alice" file "simple-folder/data.zip" should exist in the server


Scenario: copy a folder into the same folder
Given user "Alice" has created folder "simple-empty-folder" in the server
And user "Alice" has logged in using the webUI
When the user tries to copy folder "simple-empty-folder" into folder "simple-empty-folder" using the webUI
Then the "error" message with header "You can't paste the selected file at this location because you can't paste an item into itself." should be displayed on the webUI
And the user clears all error message from the webUI
And as "Alice" file "simple-empty-folder/simple-empty-folder" should not exist in the server


Scenario: copy a folder into another folder with same name
Given user "Alice" has created folder "simple-empty-folder" in the server
And user "Alice" has created folder "folder with space" in the server
And user "Alice" has created folder "folder with space/simple-empty-folder" in the server
And user "Alice" has logged in using the webUI
When the user copies folder "simple-empty-folder" into folder "folder with space/simple-empty-folder" using the webUI
Then breadcrumb for folder "folder with space" should be displayed on the webUI
And folder "simple-empty-folder" should be listed on the webUI
And as "Alice" folder "folder with space/simple-empty-folder/simple-empty-folder" should exist in the server
And as "Alice" folder "simple-empty-folder" should exist in the server
Loading