Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align lock and postprocessing info with sharing indicators #10544

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Align lock and postprocessing info with sharing indicators #10544

merged 9 commits into from
Mar 7, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 5, 2024 •
edited
Loading

Description

image
image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Mar 5, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Remove former implementation Align lock and postprocessing info with sharing indicators Mar 5, 2024
@AlexAndBear AlexAndBear marked this pull request as ready for review March 5, 2024 12:57
@AlexAndBear AlexAndBear requested review from kulmann and dschmidt March 5, 2024 12:59
@AlexAndBear AlexAndBear requested a review from JammingBen March 6, 2024 14:27
kulmann
kulmann suggested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual question in the comments... visually this is such an improvement! Much easier for the eye! 💯

packages/web-app-files/src/views/spaces/GenericSpace.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/views/spaces/GenericSpace.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from kulmann March 7, 2024 06:24
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JammingBen
JammingBen approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I feel like we should add a proper type for resource indicators as a follow-up task.

@AlexAndBear
Copy link
Contributor Author

LGTM 👍

I feel like we should add a proper type for resource indicators as a follow-up task.

Sure 👍 but I think this sprint is quite too tight to do so

kulmann
kulmann approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loving it! ❤️‍🔥

@kulmann kulmann merged commit 7f5c74e into master Mar 7, 2024
3 checks passed
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
@kulmann kulmann deleted the issues/10538# branch September 5, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align lock and postprocessing info with sharing indicators
3 participants
@AlexAndBear @kulmann @JammingBen