Share sidebar icon fixes #10551
Merged
Share sidebar icon fixes #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
share-sidebar-icon-fixes
branch
from
a9ff453 to
c55fdef
Compare
AlexAndBear
approved these changes
Mar 6, 2024
kulmann
force-pushed
the
share-sidebar-icon-fixes
branch
from
c55fdef to
66d7c25
Compare
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right sidebar sharing panel didn't have icons in some cases in the sharee search dropdown.
Also found that the
isVisiblecheck on app nav items was too strict and fixed it as well.Types of changes