Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only] Check that image editor open #10571

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[test-only] Check that image editor open #10571

merged 2 commits into from
Mar 12, 2024

Conversation

ScharfViktor
Copy link
Contributor

changed test in master branch for testing: owncloud/ocis#8608

@update-docs Update Docs
Copy link

update-docs bot commented Mar 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title Check that image editor open [test-only] Check that image editor open Mar 8, 2024
@ScharfViktor ScharfViktor requested a review from kobergj March 8, 2024 14:43
@ScharfViktor
Copy link
Contributor Author

@kobergj if you want to check tests with your changes -> just update ocis commitID

@ScharfViktor ScharfViktor force-pushed the checkThatImageEditorOpen branch from 364478e to f7d9e33 Compare March 11, 2024 14:38
@ScharfViktor
Copy link
Contributor Author

image

issue still relevant in CI. I cannot get why. localy works correct

@ScharfViktor
Copy link
Contributor Author

I figured out what is issue. step uploads the following local file(s) into personal space using API doesn't work correct.
looking into the problem..

@ScharfViktor ScharfViktor force-pushed the checkThatImageEditorOpen branch from 93a816c to 6574c3e Compare March 11, 2024 20:02
@ScharfViktor ScharfViktor requested a review from saw-jan March 11, 2024 20:02
@ScharfViktor ScharfViktor force-pushed the checkThatImageEditorOpen branch from 6574c3e to 32d8e91 Compare March 11, 2024 20:58
saw-jan
saw-jan approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
we also want to have it in stable-8 once the fix is ported to the ocis stable-5

@saw-jan
Copy link
Member

saw-jan commented Mar 12, 2024

we also want to have it in stable-8 once the fix is ported to the ocis stable-5

I see the PR: #10565 👍

saw-jan
saw-jan reviewed Mar 12, 2024
View reviewed changes
tests/e2e/cucumber/features/smoke/shares/link.feature
@@ -169,10 +170,35 @@ Feature: link
And "Carol" closes the file viewer
When "Carol" opens the public link "imageLink"
And "Carol" unlocks the public link with password "%public%"
# https://github.com/owncloud/ocis/issues/8602
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor I resolved the conflict and looks good from my side.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ScharfViktor ScharfViktor merged commit 6320d99 into master Mar 12, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the checkThatImageEditorOpen branch March 12, 2024 06:52
saw-jan
saw-jan reviewed Mar 13, 2024
View reviewed changes
tests/e2e/cucumber/features/smoke/shares/link.feature
Comment on lines -89 to +92
And "Alice" uploads the following local file into personal space using API
| localFile | to |
| filesForUpload/simple.pdf | simple.pdf |
| filesForUpload/testavatar.jpg | testavatar.jpg |
And "Alice" uploads the following resource
| resource |
| simple.pdf |
| testavatar.jpg |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@saw-jan saw-jan mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScharfViktor @saw-jan