Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply sandbox attribute to OnlyOffice/Collabora iframe #10706

Merged
merged 1 commit into from
Apr 4, 2024
+10 −3
Merged

fix: apply sandbox attribute to OnlyOffice/Collabora iframe #10706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog/unreleased/iframe-sandbox-drawio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Bugfix: Apply sandbox attribute to iframe in draw-io extension

General hardening of ownCloud Web
General hardening of ownCloud Web integration with draw.io

https://github.com/owncloud/web/pull/10702
5 changes: 5 additions & 0 deletions changelog/unreleased/iframe-sandbox-external.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Apply sandbox attribute to iframe in app-external extension

General hardening of ownCloud Web integration with OnlyOffice/Collabora

https://github.com/owncloud/web/pull/10706
2 changes: 2 additions & 0 deletions packages/web-app-external/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
class="oc-width-1-1 oc-height-1-1"
:title="iFrameTitle"
allowfullscreen
sandbox="allow-scripts allow-same-origin"
/>
<div v-if="appUrl && method === 'POST' && formParameters" class="oc-height-1-1 oc-width-1-1">
<form :action="appUrl" target="app-iframe" method="post">
Expand All @@ -18,6 +19,7 @@
class="oc-width-1-1 oc-height-1-1"
:title="iFrameTitle"
allowfullscreen
sandbox="allow-scripts allow-same-origin"
/>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions packages/web-app-external/tests/unit/__snapshots__/app.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`The app provider extension > should be able to load an iFrame via get 1`] = `
"<iframe src="https://example.test/d12ab86/loe009157-MzBw" class="oc-width-1-1 oc-height-1-1" title="" example-app" app content area" allowfullscreen=""></iframe>
"<iframe src="https://example.test/d12ab86/loe009157-MzBw" class="oc-width-1-1 oc-height-1-1" title="" example-app" app content area" allowfullscreen="" sandbox="allow-scripts allow-same-origin"></iframe>

<!--v-if-->"
`;
Expand All @@ -13,7 +13,7 @@ exports[`The app provider extension > should be able to load an iFrame via post
<form action="https://example.test/d12ab86/loe009157-MzBw" target="app-iframe" method="post"><input type="submit" class="oc-hidden" value="[object Object]">
<div><input name="access_token" type="hidden" value="asdfsadfsadf"></div>
<div><input name="access_token_ttl" type="hidden" value="123456"></div>
</form> <iframe name="app-iframe" class="oc-width-1-1 oc-height-1-1" title="" example-app" app content area" allowfullscreen=""></iframe>
</form> <iframe name="app-iframe" class="oc-width-1-1 oc-height-1-1" title="" example-app" app content area" allowfullscreen="" sandbox="allow-scripts allow-same-origin"></iframe>
</div>"
`;

Expand Down