Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sse enhancements #10709

Merged
merged 9 commits into from
Apr 8, 2024
Merged

Sse enhancements #10709

merged 9 commits into from
Apr 8, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 4, 2024 •
edited
Loading

Description

  • Add SSE event handler for folder-created
  • Add SSE event handler for file-touched
  • Enable SSE Event handling for file uploaded (finish postprocessing)
  • Add logic to not trigger SSE Logic when the client (tracked down to browser tab) was the initiator
  • Fix bug, where text file thumbnail was not rendered on purpose (too short) in table view but in tiles view

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Apr 4, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review April 5, 2024 10:52
@AlexAndBear AlexAndBear requested a review from JammingBen April 8, 2024 08:14
kulmann
kulmann approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pure gold 😍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
22.3% Coverage on New Code
39.5% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit e76186d into master Apr 8, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sse-enhancements branch April 8, 2024 13:13
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Implement Event "New resource"
3 participants
@AlexAndBear @kulmann @JammingBen