Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize version loading #10746

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Centralize version loading #10746

merged 11 commits into from
Apr 9, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 8, 2024 •
edited
Loading

Description

We've fixed a bug, where the versions endpoint was fetched multiple times when the sidebar was opened
and therefore added unnecessary load to the server.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Apr 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title Centrelize version loading Centralize version loading Apr 8, 2024
@AlexAndBear AlexAndBear marked this pull request as ready for review April 8, 2024 16:48
@AlexAndBear AlexAndBear requested a review from kulmann April 8, 2024 21:16
JammingBen
JammingBen approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear enabled auto-merge (squash) April 9, 2024 12:59
@AlexAndBear AlexAndBear merged commit 70d7033 into master Apr 9, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/10381 branch April 9, 2024 13:07
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opening the right sidebar fetches versions twice Stop loading versions separately in each sidebar panel
4 participants
@AlexAndBear @dschmidt @kulmann @JammingBen