Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add e2e test coverage for filename with hash #10812

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Apr 22, 2024

Description

This PR adds the steps for downloading file/folder with hash # in their name. When user tries to download file/folder with hash in its name, then the download fails with 404 error on ocis 5.0.2.

Test coverage for issue #10810

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@phil-davis
Copy link
Contributor

It would also be good to cover names with a literal "%" character in them. Specially a file that literally has "%20" in it name - that looks like it could be a space!
Some name like text%20.txt might make things explode.

A name like dataFromLastMonth?.txt might also make things explode.

@PrajwolAmatya PrajwolAmatya force-pushed the test/download-file-with-hash branch from 4dac6a8 to 903c80c Compare April 23, 2024 07:01
@PrajwolAmatya
Copy link
Contributor Author

PrajwolAmatya commented Apr 23, 2024

It would also be good to cover names with a literal "%" character in them. Specially a file that literally has "%20" in it name - that looks like it could be a space! Some name like text%20.txt might make things explode.

A name like dataFromLastMonth?.txt might also make things explode.

With these filename, the file gets downloaded but with different names.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PrajwolAmatya PrajwolAmatya requested a review from saw-jan April 23, 2024 07:12
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add extra tests for %20 in separate PR after merging #10817

@ScharfViktor ScharfViktor merged commit 8bbbc7e into stable-8.0 Apr 23, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test/download-file-with-hash branch April 23, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants