fix: remove user locally if no logout url in IdP #10974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
fix-missing-logout-url
branch
from
f9ea063 to
19dc4c1
Compare
|
Currently thinking about how to test this properly. I'm looking into setting up authelia (because that doesn't have an |
kulmann
commented
May 31, 2024
| @@ -82,7 +82,6 @@ export default defineComponent({ | |||
| } | |||
| } | |||
| return { | |||
| name: 'login', | |||
There was a problem hiding this comment.
No idea why we had the name key here... maybe just by mistake and it was really meant for the to route?!
JammingBen
approved these changes
May 31, 2024
)
Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
|
3 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are IdPs without an
endSessionEndpoint(e.g. Authelia). In those cases we just need to unload the currently authenticated user.Related Issue
Motivation and Context
Hardening.
Types of changes