Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove allow-same-origin from drawio iframe sandbox #11010

Closed
wants to merge 1 commit into from

Conversation

DeepDiver1975
Copy link
Member

Description

Drawio v24.5.2 no longer requires allow-same-origin

jgraph/drawio#4340

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Jun 7, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the feat/drawio-sandbox branch from 4de6194 to 27b16f5 Compare June 7, 2024 12:31
@dschmidt
Copy link
Member

CI is failing:

  ✖ And "Alice" creates the following resources # tests/e2e/cucumber/steps/ui/resources.ts:19

       | resource            | type       | content   |

       | shareToBrian.txt    | txtFile    | some text |

       | shareToBrian.md     | mdFile     | readme    |

       | shareToBrian.drawio | drawioFile |           |

       | sharedFile.txt      | txtFile    | some text |

       locator.click: Timeout 30000ms exceeded.

       =========================== logs ===========================

       waiting for frameLocator('#drawio-editor').locator('.geBigButton').locator('text=Save')

       ============================================================

           at createNewFileOrFolder (/var/www/owncloud/web/tests/e2e/support/objects/app-files/resource/actions.ts:311:71)

           at async Object.createResources (/var/www/owncloud/web/tests/e2e/support/objects/app-files/resource/actions.ts:488:3)

           at async Resource.create (/var/www/owncloud/web/tests/e2e/support/objects/app-files/resource/index.ts:15:5)

           at async World.<anonymous> (/var/www/owncloud/web/tests/e2e/cucumber/steps/ui/resources.ts:26:7)

@DeepDiver1975
Copy link
Member Author

@dschmidt any idea why? 🤷

@DeepDiver1975
Copy link
Member Author

Who can help out on the failing acceptance test.

@kulmann
Copy link
Contributor

kulmann commented Jun 13, 2024

Who can help out on the failing acceptance test.

For the first pipeline please do a rebase, that's unrelated to your PR. Translations were broken in master Friday to Monday.

@DeepDiver1975
Copy link
Member Author

🤷

@ScharfViktor
Copy link
Contributor

I see here 2 failed steps:

  • And "Alice" sets the expiration date of share it's flaky, please rebase
And "Alice" creates the following resources
      │ shareToBrian.drawio │ drawioFile │ 

here is problem - endless loading when open/create file in drawio
image

trace for that (just put to terminal): npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/45208/tracing/file-alice-2024-6-17-10-52-24.zip

@kulmann
Copy link
Contributor

kulmann commented Jun 17, 2024

🤷

another rebase needed after #11051 🙈

@DeepDiver1975
Copy link
Member Author

Just saw the same behavior on oc10 drawio ...... why? just why?

@DeepDiver1975 DeepDiver1975 marked this pull request as draft June 17, 2024 12:58
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DeepDiver1975
Copy link
Member Author

jgraph/drawio#4483

@DeepDiver1975 DeepDiver1975 deleted the feat/drawio-sandbox branch July 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants