-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove allow-same-origin from drawio iframe sandbox #11010
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
4de6194
to
27b16f5
Compare
CI is failing:
|
@dschmidt any idea why? 🤷 |
Who can help out on the failing acceptance test. |
For the first pipeline please do a rebase, that's unrelated to your PR. Translations were broken in master Friday to Monday. |
27b16f5
to
1165977
Compare
🤷 |
I see here 2 failed steps:
here is problem - endless loading when open/create file in drawio trace for that (just put to terminal): npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/45208/tracing/file-alice-2024-6-17-10-52-24.zip |
another rebase needed after #11051 🙈 |
1165977
to
aca7741
Compare
Just saw the same behavior on oc10 drawio ...... why? just why? |
Quality Gate passedIssues Measures |
Description
Drawio v24.5.2 no longer requires
allow-same-origin
jgraph/drawio#4340
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: