fix: visiting public links with expired access token #11086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
approved these changes
Jun 24, 2024
changelog/unreleased/bugfix-opening-public-links-with-expired-token
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix/public-link-token-expiry
branch
from
62635d4
to
3ddc3bd
Compare
JammingBen
force-pushed
the
fix/public-link-token-expiry
branch
from
3ddc3bd
to
217cd31
Compare
|
AlexAndBear
approved these changes
Jun 28, 2024
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where opening public links with an expired token would falsely show the access denied page. Instead, Web now tries to login the user. If that doesn't work, the user gets logged out.
Related Issue
Types of changes