Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: secure view default action #11139

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

JammingBen
Copy link
Collaborator

Description

Prevents files that have been shared via secure view without having a compatible app to view such (or the file type is not supported) from being clicked.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jul 4, 2024
@JammingBen JammingBen force-pushed the fix/secure-view-default-action branch 6 times, most recently from cc6be49 to 9a099fb Compare July 4, 2024 09:56
Prevents files that have been shared via secure view without having a compatible app to view such (or the file type is not supported) from being clicked.
@JammingBen JammingBen force-pushed the fix/secure-view-default-action branch from 9a099fb to 7686e84 Compare July 4, 2024 10:18
Copy link

sonarcloud bot commented Jul 4, 2024

@JammingBen JammingBen requested a review from kulmann July 4, 2024 10:46
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 🛡️

@JammingBen JammingBen merged commit fb288fd into master Jul 4, 2024
3 checks passed
@micbar micbar mentioned this pull request Jul 8, 2024
19 tasks
@kulmann kulmann deleted the fix/secure-view-default-action branch September 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Secure View] If no secure view app is present, default action is "hide share"
2 participants