Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename status column to info column, add share role icon #11166

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Rename status column to info column, add share role icon #11166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c80da
Rename status column to info column, add share role icon
AlexAndBear Jul 9, 2024
81580b3
Add changelog item
AlexAndBear Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-add-share-role-icon-to-shared-with-me-table
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Add share role icon to shared with me table

We've added the respective share role icon with a tooltip that contains the share role name to each share column,
so the user knows which permission they have in a share.

https://github.com/owncloud/web/pull/11166
https://github.com/owncloud/web/issues/11101
7 changes: 6 additions & 1 deletion packages/web-app-files/src/components/Shares/SharedWithMeSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,17 @@
:key="resource.getDomSelector()"
class="oc-text-nowrap oc-flex oc-flex-middle oc-flex-right"
>
<oc-icon
v-oc-tooltip="$gettext(resource.shareRoles[0].displayName)"
:name="resource.shareRoles[0].icon"
fill-type="line"
/>
<oc-icon
v-if="resource.syncEnabled"
v-oc-tooltip="$gettext('Synced with your devices')"
:accessible-label="$gettext('Synced with your devices')"
name="loop-right"
class="sync-enabled"
class="sync-enabled oc-ml-s"
/>
</div>
</template>
Expand Down
2 changes: 1 addition & 1 deletion packages/web-pkg/src/components/FilesList/ResourceTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ export default defineComponent({
},
{
name: 'syncEnabled',
title: this.$gettext('Status'),
title: this.$gettext('Info'),
type: 'slot',
alignH: 'right',
wrap: 'nowrap',
Expand Down