-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: horizontal resource table scroll #11313
Conversation
bacb1b2
to
4337cbb
Compare
Prevents resource tables from being horizontally scrollable for a11y reasons. Instead, information that is available elsewhere will get hidden on smaller displays.
4337cbb
to
9f7a2c4
Compare
ftr I changed the PR description from |
Yes I can do that, but selection will be jumpy then because we add new vertical space that wasn't there before.
I discussed that with @tbsbdr : it's not that easy because it's just a In general I thought the goal of this issue is to make it a11y-conform. Making things actually look nice on small screens is certainly possible, but we would need to allocate a lot more time for that.
I can't reproduce that 🤔 What's your vertical screen size? |
This is bad because it causes the screen to allow horizontal scroll on small screens.
Quality Gate passedIssues Measures |
@kulmann I fixed the horizontal scroll for production build, can you please check if the spaces page is still scrollable? For the breadcrumbs, as discussed, let's not solve this via a new line because it's too jumpy. This could be solved via a context menu, but not in the scope of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good now 👍 When I navigate to the spaces overview while having 100% and then zooming in to 400% breaks the spaces overview, but it works fine on page reload then.
Description
Prevents resource tables from being horizontally scrollable for a11y reasons. Instead, information that is available elsewhere will get hidden on smaller displays.
Related Issue
Types of changes