Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase padding on create link password field, change clipboard link #11324

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Increase padding on create link password field, change clipboard link #11324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94f9404
Increase margin on create link password field, change clipboard link
AlexAndBear Aug 5, 2024
e17e3db
Enhance changelog item
AlexAndBear Aug 5, 2024
8e22980
Fix: passwords are html escaped
AlexAndBear Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-redesign-share-link-modal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ We've redesigned the share link modal to make it easier to share.
The new modal is more user-friendly and provides a better experience for sharing.

https://github.com/owncloud/web/pull/11310
https://github.com/owncloud/web/pull/11324
https://github.com/owncloud/web/issues/11204
2 changes: 1 addition & 1 deletion packages/web-pkg/src/components/CreateLinkModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<span v-text="$gettext('Options')" />
</oc-button>
</div>
<div v-if="!onlyInternalLinksAllowed" class="link-modal-password">
<div v-if="!onlyInternalLinksAllowed" class="link-modal-password oc-mb-m">
<oc-text-input
v-if="advancedMode"
:key="passwordInputKey"
Expand Down
12 changes: 8 additions & 4 deletions packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,14 @@ export const useFileActionsCreateLink = ({
// Only copy to clipboard if the user tries to create one single link
try {
const copyToClipboardText = password
? $gettext('Link:%{link} Password:%{password}', {
link: succeeded[0].value.webUrl,
password
})
? $gettext(
'%{link} Password:%{password}',
{
link: succeeded[0].value.webUrl,
password
},
true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoopsie, passwords were html escaped 🤯

)
: succeeded[0].value.webUrl

await copyToClipboard(copyToClipboardText)
Expand Down