Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support a as component type in actions #11502

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 2, 2024

Description

Actions were only allowed to be of type button or router-link. This PR adds support for a tags and at the same time fixes a FIXME by determining the component type implicitly in a fallback chain by presence of certain callbacks.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Sep 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann changed the title feat: support a as component type in actions feat: support a as component type in actions Sep 2, 2024
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but there are several places where componentType still needs to be removed (including docs).

Copy link

sonarcloud bot commented Sep 2, 2024

Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kulmann kulmann merged commit 289f0eb into master Sep 3, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Sep 3, 2024
* feat: support a as component type in actions
@kulmann kulmann deleted the a-href-support-for-actions branch September 5, 2024 19:45
@micbar micbar mentioned this pull request Sep 12, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants