-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] report tracings of failing tests only #11571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
requested review from
ishabaral,
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya and
ScharfViktor
September 12, 2024 08:19
saw-jan
requested review from
prashant-gurung899,
nirajacharya2 and
SagarGi
September 12, 2024 09:07
7 tasks
saw-jan
force-pushed
the
tests/tracings-on-fail-only
branch
from
September 13, 2024 04:25
153d26e
to
cb32c86
Compare
Quality Gate passedIssues Measures |
ScharfViktor
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
6 tasks
saw-jan
added a commit
that referenced
this pull request
Sep 13, 2024
* test: save the tracing reports of failed tests only * test: bump ocis * test: disable tracing by default * bump web commit for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we get the tracing reports of all the tests that have been retried regardless of pass or fail. And with keycloak tracing is enabled which causes all tracing to be reported for all tests.
Report only the tracings of failed tests. With this PR, now we should get the tracing reports of failed tests only.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: