Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add min oCIS to app releases table #11580

Merged
merged 1 commit into from
Sep 16, 2024
Merged

feat: add min oCIS to app releases table #11580

merged 1 commit into from
Sep 16, 2024

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Sep 13, 2024 •
edited
Loading

Description

This PR adds a minOCIS field to the app version schema and displays its value in the app releases table in the app store app details.

Motivation and Context

Show min required ocis version to admins.

Screenshots (if appropriate):

Screenshot 2024-09-13 at 15 42 57

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@update-docs Update Docs
Copy link

update-docs bot commented Sep 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann self-assigned this Sep 13, 2024
@kulmann kulmann force-pushed the ocis-min-version-app-store branch from 678be48 to f4bb588 Compare September 13, 2024 13:47
AlexAndBear
AlexAndBear approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather go with minOCIS in that case but approving anyways

@kulmann kulmann force-pushed the ocis-min-version-app-store branch from f4bb588 to 6dfec15 Compare September 13, 2024 13:51
@kulmann kulmann force-pushed the ocis-min-version-app-store branch from 6dfec15 to dad0fc8 Compare September 13, 2024 13:56
@kulmann
Copy link
Contributor Author

kulmann commented Sep 13, 2024

I'd rather go with minOCIS in that case but approving anyways

changed it, thank you :-)

@kulmann kulmann mentioned this pull request Sep 13, 2024
Merged
@kulmann kulmann enabled auto-merge September 16, 2024 04:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kulmann kulmann merged commit d657b29 into master Sep 16, 2024
3 checks passed
@kulmann kulmann deleted the ocis-min-version-app-store branch September 16, 2024 04:45
@micbar micbar mentioned this pull request Oct 1, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @AlexAndBear