Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add min oCIS to app releases table #11580

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 13, 2024

Description

This PR adds a minOCIS field to the app version schema and displays its value in the app releases table in the app store app details.

Motivation and Context

Show min required ocis version to admins.

Screenshots (if appropriate):

Screenshot 2024-09-13 at 15 42 57

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Sep 13, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather go with minOCIS in that case but approving anyways

@kulmann
Copy link
Member Author

kulmann commented Sep 13, 2024

I'd rather go with minOCIS in that case but approving anyways

changed it, thank you :-)

Copy link

sonarcloud bot commented Sep 16, 2024

@kulmann kulmann merged commit d657b29 into master Sep 16, 2024
3 checks passed
@kulmann kulmann deleted the ocis-min-version-app-store branch September 16, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants