fix(a11y): contrast, checkbox focus and space member search label #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
changed the title
JammingBen
force-pushed
the
fix/contrasts-controll-elements
branch
2 times, most recently
from
e280d1a
to
dbf25f2
Compare
JammingBen
commented
Sep 17, 2024
| @@ -1,7 +1,6 @@ | |||
| <template> | |||
| <tr | |||
| ref="observerTarget" | |||
| tabindex="-1" | |||
There was a problem hiding this comment.
I don't see a reason to set tabindex="-1" here. A tr can't be focused and we don't have a scenario where we want to focus it programmatically.
Fixes the issue where the current focus would not change when navigating the resource table/tiles with the keyboard.
Redesigns the space member search in the right sidebar so it has a label. Also moves the search from the top of the sharing panel to the members section where all members are listed.
JammingBen
force-pushed
the
fix/contrasts-controll-elements
branch
from
dbf25f2
to
9614934
Compare
5 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes