fix(a11y): keyboard navigation #11600
Conversation
JammingBen
force-pushed
the
fix/more-a11y-fixes
branch
5 times, most recently
from
6fab180 to
ccb69d9
Compare
Automatically closes drops when leaving them via keyboard navigations.
Prevents background elements form being focused when the sidebar takes 100% screen with (mobile view).
JammingBen
force-pushed
the
fix/more-a11y-fixes
branch
from
ccb69d9 to
1e2c698
Compare
| if (await page.locator(closeEditPanel).count()) { | ||
| // close potentially open sidebar panel to avoid focus jumping | ||
| await page.locator(closeEditPanel).click() | ||
| } |
There was a problem hiding this comment.
Can't reproduce that locally, just happens in the tests... 🤷 So IMO nothing to worry about in the "real world".
There was a problem hiding this comment.
Loving it! 🥇 Big improvement for keyboard users. 🚀
Found a tiny glitch... if it's hard to fix please ignore it:
- TAB until you reach the app switcher
- ENTER to open the app switcher
- TAB through all the apps in the app switcher until you reach the last app
- TAB once more to leave the app switcher (app switcher closes as expected)
The focus moves to the ownCloud logo and then immediately jumps back to the app switcher toggle button. 😅
|
Good catch, hmm. 93b9d81 provides a fix, but I'm debating if we should remove this re-focus thing. Problem though: when having the right sidebar open and then navigating e.g. to the admin-settings app, the sidebar will steal the focus. I guess the re-focus is there to prevent this. |
|
Description
Related Issue
Types of changes