Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move "Shared via"-indicator in sidebar to context menu #11626

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

JammingBen
Copy link
Collaborator

Description

Follow-up for #11606.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Sep 23, 2024
@JammingBen JammingBen force-pushed the feat/shared-parent-to-context-menu branch from 4140c90 to 2b9d64d Compare September 23, 2024 08:19
@JammingBen JammingBen marked this pull request as draft September 23, 2024 08:28
@JammingBen JammingBen force-pushed the feat/shared-parent-to-context-menu branch from 2b9d64d to 2f0dcae Compare September 23, 2024 11:21
@JammingBen JammingBen force-pushed the feat/shared-parent-to-context-menu branch from 2f0dcae to 9890c5e Compare September 23, 2024 13:04
Copy link

sonarcloud bot commented Sep 23, 2024

@JammingBen JammingBen marked this pull request as ready for review September 24, 2024 07:52
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI/UX review:

  • Shared via indicator in indirect shares is not clickable while for the indirect links it is clickable. Could you make the indirect share one clickable as well?
  • Navigate to parent context menu item is below the Access details context menu item. I'd prefer to have Access details always as the very last item in the list. Do you agree?

@kulmann
Copy link
Member

kulmann commented Sep 24, 2024

  • Shared via indicator in indirect shares is not clickable while for the indirect links it is clickable. Could you make the indirect share one clickable as well?

As discussed: let's keep it as an indicator without link, since the other PR removes it entirely anyway. "Make it consistent" is not applicable anymore then.

  • Navigate to parent context menu item is below the Access details context menu item. I'd prefer to have Access details always as the very last item in the list. Do you agree?

Pedaling back on this one. Let's keep it like it is.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 💪

@JammingBen JammingBen merged commit 7806ca3 into master Sep 24, 2024
3 checks passed
@JammingBen JammingBen deleted the feat/shared-parent-to-context-menu branch September 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "Shared via" indicator in sharing panel to context action
2 participants