feat(perf): improve preview loading #11631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JammingBen
force-pushed
the
feat/lazy-preview-loading
branch
6 times, most recently
from
f2a6b4d
to
e2a4ba2
Compare
* Adds a limit of parallel preview requests to prevent the server from being overrun with requests * Cancels ongoing and queued preview requests when they are aborted (e.g. when leaving the page) * Adds lazy loading for space images * Prevents the image resource from being fetched for each space * Uses caching for space images Also introduces a global `loadPreview` method and removes the visibility observers in each view. Previews are now loaded event-based instead, which should result in a better performance overall.
JammingBen
force-pushed
the
feat/lazy-preview-loading
branch
from
e2a4ba2
to
a28b127
Compare
kulmann
reviewed
Sep 24, 2024
Removes this feature as it only adds complexity and very little value.
|
kulmann
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also introduces a global
loadPreviewmethod and removes the visibility observers in each view. Previews are now loaded event-based instead, which should result in a better performance overall.Related Issue
Types of changes