Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end to end tests for app store #11664

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add end to end tests for app store #11664

merged 1 commit into from
Sep 27, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Sep 26, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Sep 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

Idea for the future: since the app store allows adding a custom repository, maybe we should do that with some mock data that we add to our test package. It would remove the external dependency it currently has, which feels a bit unstable to me.

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Sep 27, 2024

Awesome 🚀

Idea for the future: since the app store allows adding a custom repository, maybe we should do that with some mock data that we add to our test package. It would remove the external dependency it currently has, which feels a bit unstable to me.

Talked about that with @kulmann already and we decided not to mock the data for now, to have the "near to reality experience". Let's see how stable this will be...

Unit Tests will indeed use mock data.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff ❤️

@AlexAndBear AlexAndBear merged commit 7931556 into master Sep 27, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the app-store-e2e branch September 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants