-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end to end tests for app store #11664
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
10977a6
to
eecf0f3
Compare
eecf0f3
to
f9f9bb9
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
Idea for the future: since the app store allows adding a custom repository, maybe we should do that with some mock data that we add to our test package. It would remove the external dependency it currently has, which feels a bit unstable to me.
Talked about that with @kulmann already and we decided not to mock the data for now, to have the "near to reality experience". Let's see how stable this will be... Unit Tests will indeed use mock data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff ❤️
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: