Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict shortcut name #11707

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Restrict shortcut name #11707

merged 2 commits into from
Oct 2, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 2, 2024

Description

As per title.
Note that we don't need to be as restrictive as in packages/web-pkg/src/composables/actions/files/useFileActionsCreateNewFile.tssince we always append the .url extension

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Oct 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix changelog item please, as this closes an issue :-)

@AlexAndBear AlexAndBear requested a review from kulmann October 2, 2024 12:02
Copy link

sonarqubecloud bot commented Oct 2, 2024

@AlexAndBear AlexAndBear merged commit 7e2fe95 into master Oct 2, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the issues/11702 branch October 2, 2024 13:02
@micbar micbar mentioned this pull request Oct 21, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shortcut name can contain invalid characters
3 participants