Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general not found page #11737

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Add general not found page #11737

merged 4 commits into from
Oct 9, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Oct 8, 2024

Description

We've added a not found page to communicate to users when they've navigated to a page that doesn't exist.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Oct 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 😍 Care to add an e2e test for the page?

Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

I want to see a not found page
So that I know when I've navigated to a page that doesn't exist

Scenario: not found page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a second one for "the public" (i.e. anonymous access)? Important that the page also works unauthenticated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we found out in a meeting: we can't offer the notFound page in an anonymous context at the moment: user doesn't get initialized and more importantly, apps don't get initialized in an anonymous context. We might change that in the future, but for now we need to accept that the notFound page only works in user- and publicLink-contexts.

@AlexAndBear AlexAndBear merged commit 35ab0e2 into master Oct 9, 2024
2 of 3 checks passed
@AlexAndBear AlexAndBear deleted the issues/5804 branch October 9, 2024 09:11
@kulmann kulmann mentioned this pull request Oct 9, 2024
@micbar micbar mentioned this pull request Oct 21, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not found page
3 participants