-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add general not found page #11737
Add general not found page #11737
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! 😍 Care to add an e2e test for the page?
Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
I want to see a not found page | ||
So that I know when I've navigated to a page that doesn't exist | ||
|
||
Scenario: not found page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a second one for "the public" (i.e. anonymous access)? Important that the page also works unauthenticated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we found out in a meeting: we can't offer the notFound page in an anonymous context at the moment: user doesn't get initialized and more importantly, apps don't get initialized in an anonymous context. We might change that in the future, but for now we need to accept that the notFound page only works in user- and publicLink-contexts.
Description
We've added a not found page to communicate to users when they've navigated to a page that doesn't exist.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: