Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting post logout redirect url #11817

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: setting post logout redirect url #11817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b0cb9
fix: setting post logout redirect url
Oct 24, 2024
96f71d0
feat: allow potential unknown props in OpenIdConnectConfigSchema
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-respect-post-logout-url
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Respect post logout url

We've fixed a bug where setting the `post_logout_redirect_url` in the oidc config had no effect.

https://github.com/owncloud/web/pull/11817
https://github.com/owncloud/web/issues/11816
21 changes: 12 additions & 9 deletions packages/web-pkg/src/composables/piniaStores/config/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,18 @@ const OAuth2ConfigSchema = z.object({

export type OAuth2Config = z.infer<typeof OAuth2ConfigSchema>

const OpenIdConnectConfigSchema = z.object({
authority: z.string().optional(),
client_id: z.string().optional(),
client_secret: z.string().optional(),
dynamic: z.string().optional(),
metadata_url: z.string().optional(),
response_type: z.string().optional(),
scope: z.string().optional()
})
const OpenIdConnectConfigSchema = z
.object({
authority: z.string().optional(),
client_id: z.string().optional(),
client_secret: z.string().optional(),
dynamic: z.string().optional(),
metadata_url: z.string().optional(),
post_logout_redirect_uri: z.string().optional(),
response_type: z.string().optional(),
scope: z.string().optional()
})
.passthrough()

export type OpenIdConnectConfig = z.infer<typeof OpenIdConnectConfigSchema>

Expand Down