Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: always, show location in top bar, make file picker work in various locations, file picker width too narrow #11900

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix: always, show location in top bar, make file picker work in various locations, file picker width too narrow #11900

merged 2 commits into from
Nov 13, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Nov 13, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@AlexAndBear AlexAndBear marked this pull request as ready for review November 13, 2024 12:47
@AlexAndBear
Copy link
Contributor Author

Opened an additional issue in OCIS repo owncloud/ocis#10562 so we can remove the workaround later

JammingBen
JammingBen reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found 2 little bugs while testing.

changelog/unreleased/bugfix-app-top-bar-does-not-show-location-when-shared-file-is-opened Outdated Show resolved Hide resolved
packages/web-pkg/src/components/AppTopBar.vue Show resolved Hide resolved
packages/web-pkg/src/composables/folderLink/useFolderLink.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AlexAndBear AlexAndBear merged commit 7bd1bff into master Nov 13, 2024
3 checks passed
@AlexAndBear AlexAndBear deleted the issues/11896+issues/11895 branch November 13, 2024 17:52
JammingBen pushed a commit that referenced this pull request Nov 14, 2024
@AlexAndBear @JammingBen
Fix: always, show location in top bar, make file picker work in vario…
b31aea5 
…us locations, file picker width too narrow (#11900)
@JammingBen JammingBen mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AlexAndBear @JammingBen