Multiple fixes found when running web with CERNBox #11946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The results were not being taken into account.
When TUS is not supported by the backend, web crashed trying to see if the user had permissions to upload. Even if they did, it was being denied due to that crash.
Remove deprecated code.
…not report their parent The parameter Resource.parentFolderId is optional, so it should be treated as so in other places.
The configuration was being ignored.
The current implementation hardcodes this and assumes that the personal volume always starts with `personal/`, which might not be the case.
diocas
force-pushed
the
up_fixes1
branch
2 times, most recently
from
cd7c9da to
10f9e93
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes are described in the changelog.
Most of the cases are error handling of things that your server returns but ours might not. But, for example, the lack of parent ID should be treated by Web, since in the code is marked as optional, so I would argue it is not correct to just crash if not set. Same for TUS support, if not configured it just crashed to upload, which should not.
For the preview service, I think that when the object was created, the store was not loaded yet. So, whatever config I returned in the capabilities, the listing of files would always render all the hardcoded mime types.
But let me know if you have a proper way/different way of solving the issue.
More to come!