Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show indirect shares in search results #12050

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Dec 19, 2024

Description

We've fixed an issue where the indirect shares of resources were not displayed in the sidebar when user is on search page.

Related Issue

Motivation and Context

🐛less code

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: add unit tests to check whether ancestors metadata are loaded on search page
  • test case 2: follow reproduction steps in chrome

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • add tests
  • add changelog item

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Dec 19, 2024
@LukasHirt LukasHirt self-assigned this Dec 19, 2024
Load ancestors metadata to get indirect shares on search page.
@LukasHirt LukasHirt force-pushed the fix/missing-indirect-shares branch from fcf716c to df4d950 Compare December 20, 2024 09:10
@LukasHirt LukasHirt requested a review from saw-jan December 20, 2024 09:11
@LukasHirt LukasHirt marked this pull request as ready for review December 20, 2024 09:11
@owncloud owncloud deleted a comment from update-docs bot Dec 20, 2024
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 531a70d into master Dec 23, 2024
4 checks passed
@LukasHirt LukasHirt deleted the fix/missing-indirect-shares branch December 23, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Indirect shares are not showing on search result page
2 participants