Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the name ends with whitespace #1373

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Check if the name ends with whitespace #1373

merged 2 commits into from
Jul 6, 2019

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jun 26, 2019 •
edited
Loading

Description

Prevents creation/rename of file/folder with whitespace as the last character.

Motivation and Context

Trailing whitespaces can lead to problems with sync client and in download.

Related issue

Fixes https://github.com/owncloud/smb_acl_frontend/issues/82

How Has This Been Tested?

  • test environment: Manually
  • test case 1: Append a whitespace when renaming a file
  • test case 2: Append a whitespace when creating a file
  • test case 3: Append a whitespace when creating a folder

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Come up with better error message

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Jun 26, 2019
@LukasHirt LukasHirt self-assigned this Jun 26, 2019
@LukasHirt LukasHirt force-pushed the bugfix/prevent-whitespace-at-the-end-of-name branch from 5a9de58 to ab50e69 Compare June 26, 2019 12:18
@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3585/23

20190626-124109-313.png
20190626-124109-472.png
20190626-124109-615.png
20190626-124109-790.png
20190626-124109-997.png
20190626-124110-219.png
20190626-124202-604.png
20190626-124202-909.png
20190626-124203-185.png
20190626-124203-451.png
20190626-124203-820.png
20190626-124203-985.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/6

20190627-120406-294.png
20190627-120423-567.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/13

20190627-120405-567.png
20190627-120441-067.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/14

20190627-120529-412.png
20190627-120556-673.png
20190627-120624-991.png
20190627-120650-484.png
20190627-120715-311.png
20190627-120741-035.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/9

20190627-120441-297.png
20190627-120515-872.png
20190627-120540-892.png
20190627-120605-302.png
20190627-120629-824.png
20190627-120704-227.png
20190627-120728-960.png
20190627-120753-666.png
20190627-120817-746.png
20190627-120853-020.png
20190627-120917-814.png
20190627-120942-472.png
20190627-121006-192.png
20190627-121033-608.png
20190627-121059-621.png
20190627-121122-557.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/4

20190627-120419-592.png
20190627-120441-590.png
20190627-120513-701.png
20190627-120547-659.png
20190627-120609-099.png
20190627-120630-902.png
20190627-120702-049.png
20190627-120733-668.png
20190627-120806-483.png
20190627-120838-768.png
20190627-120900-344.png
20190627-120922-232.png
20190627-120943-291.png
20190627-121005-386.png
20190627-121028-151.png
20190627-121050-640.png
20190627-121112-949.png
20190627-121134-872.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIUpload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/19

20190627-120446-465.png
20190627-120508-662.png
20190627-120531-191.png
20190627-120603-540.png
20190627-120625-770.png
20190627-120648-403.png
20190627-120711-953.png
20190627-120735-849.png
20190627-120759-110.png
20190627-120821-618.png
20190627-120844-268.png
20190627-120908-135.png
20190627-120940-860.png
20190627-121004-748.png
20190627-121037-611.png
20190627-121100-355.png
20190627-121133-581.png
20190627-121206-560.png
20190627-121229-249.png
20190627-121251-706.png
20190627-121314-899.png
20190627-121338-121.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/8

20190627-120300-039.png
20190627-120322-773.png
20190627-120354-805.png
20190627-120416-325.png
20190627-120438-371.png
20190627-120500-777.png
20190627-120525-749.png
20190627-120549-700.png
20190627-120611-700.png
20190627-120634-064.png
20190627-120658-751.png
20190627-120720-332.png
20190627-120741-999.png
20190627-120804-036.png
20190627-120828-196.png
20190627-120848-748.png
20190627-120909-940.png
20190627-120930-622.png
20190627-120953-584.png
20190627-121015-721.png
20190627-121038-724.png
20190627-121059-816.png
20190627-121121-315.png
20190627-121143-703.png
20190627-121205-295.png
20190627-121226-815.png
20190627-121249-188.png
20190627-121310-705.png
20190627-121342-549.png
20190627-121404-017.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/23

20190627-120459-415.png
20190627-120521-768.png
20190627-120543-080.png
20190627-120603-984.png
20190627-120626-471.png
20190627-120647-922.png
20190627-120710-764.png
20190627-120731-753.png
20190627-120754-071.png
20190627-120815-280.png
20190627-120836-617.png
20190627-120857-444.png
20190627-120923-580.png
20190627-120950-155.png
20190627-121011-779.png
20190627-121033-737.png
20190627-121055-023.png
20190627-121117-213.png
20190627-121138-673.png
20190627-121210-553.png
20190627-121232-162.png
20190627-121255-085.png
20190627-121326-412.png
20190627-121347-965.png
20190627-121420-419.png
20190627-121458-812.png
20190627-121531-548.png
20190627-121604-381.png
20190627-121639-838.png
20190627-121709-375.png
20190627-121739-099.png
20190627-121807-414.png
20190627-121833-296.png
20190627-121905-403.png
20190627-121939-367.png
20190627-122004-978.png
20190627-122033-751.png
20190627-122055-977.png
20190627-122121-780.png
20190627-122146-055.png
20190627-122210-206.png
20190627-122232-086.png
20190627-122255-292.png
20190627-122328-606.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/24

20190627-120628-370.png
20190627-120650-952.png
20190627-120714-678.png
20190627-120738-298.png
20190627-120801-235.png
20190627-120824-164.png
20190627-120846-888.png
20190627-120909-757.png
20190627-120932-802.png
20190627-120954-986.png
20190627-121017-653.png
20190627-121040-646.png
20190627-121108-171.png
20190627-121136-119.png
20190627-121159-459.png
20190627-121222-535.png
20190627-121245-291.png
20190627-121308-734.png
20190627-121332-121.png
20190627-121355-572.png
20190627-121418-436.png
20190627-121452-104.png
20190627-121515-040.png
20190627-121538-462.png
20190627-121608-562.png
20190627-121639-721.png
20190627-121707-102.png
20190627-121744-849.png
20190627-121812-832.png
20190627-121840-349.png
20190627-121908-438.png
20190627-121950-628.png
20190627-122013-444.png
20190627-122035-637.png
20190627-122058-709.png
20190627-122121-413.png
20190627-122154-355.png
20190627-122217-903.png
20190627-122239-867.png
20190627-122305-659.png
20190627-122329-170.png
20190627-122350-742.png
20190627-122413-653.png
20190627-122435-651.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3593/5

20190627-120405-890.png
20190627-120428-851.png
20190627-120502-224.png
20190627-120525-995.png
20190627-120549-597.png
20190627-120612-808.png
20190627-120636-983.png
20190627-120659-971.png
20190627-120723-286.png
20190627-120756-057.png
20190627-120819-312.png
20190627-120842-479.png
20190627-120908-616.png
20190627-120943-716.png
20190627-121007-542.png
20190627-121032-251.png
20190627-121057-281.png
20190627-121120-358.png
20190627-121143-638.png
20190627-121217-831.png
20190627-121240-823.png
20190627-121304-375.png
20190627-121328-190.png
20190627-121351-576.png
20190627-121415-722.png
20190627-121439-203.png
20190627-121502-981.png
20190627-121536-992.png
20190627-121610-910.png
20190627-121634-654.png
20190627-121657-492.png
20190627-121721-135.png
20190627-121745-103.png
20190627-121808-960.png
20190627-121832-290.png
20190627-121905-547.png
20190627-121928-982.png
20190627-121952-562.png
20190627-122016-588.png
20190627-122040-616.png
20190627-122109-113.png
20190627-122138-055.png
20190627-122205-717.png
20190627-122243-876.png
20190627-122322-015.png
20190627-122349-875.png
20190627-122419-167.png
20190627-122447-273.png
20190627-122515-859.png
20190627-122544-323.png
20190627-122613-115.png
20190627-122641-805.png
20190627-122710-416.png
20190627-122738-170.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/6

20190627-134943-882.png
20190627-135001-316.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/13

20190627-135046-402.png
20190627-135117-399.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/14

20190627-135014-639.png
20190627-135040-608.png
20190627-135107-443.png
20190627-135132-667.png
20190627-135209-230.png
20190627-135234-410.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/9

20190627-134856-980.png
20190627-134919-155.png
20190627-134941-306.png
20190627-135003-519.png
20190627-135025-321.png
20190627-135055-487.png
20190627-135124-981.png
20190627-135150-265.png
20190627-135212-516.png
20190627-135244-613.png
20190627-135306-069.png
20190627-135334-502.png
20190627-135400-286.png
20190627-135423-128.png
20190627-135445-628.png
20190627-135508-089.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/4

20190627-134947-474.png
20190627-135012-781.png
20190627-135037-119.png
20190627-135102-028.png
20190627-135125-654.png
20190627-135150-530.png
20190627-135215-656.png
20190627-135239-277.png
20190627-135303-668.png
20190627-135328-480.png
20190627-135351-859.png
20190627-135415-800.png
20190627-135439-549.png
20190627-135502-876.png
20190627-135526-100.png
20190627-135549-774.png
20190627-135613-213.png
20190627-135637-463.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIUpload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/19

20190627-135036-568.png
20190627-135100-261.png
20190627-135124-217.png
20190627-135147-787.png
20190627-135211-236.png
20190627-135233-966.png
20190627-135257-254.png
20190627-135320-470.png
20190627-135342-665.png
20190627-135415-700.png
20190627-135437-995.png
20190627-135501-117.png
20190627-135524-647.png
20190627-135547-109.png
20190627-135620-124.png
20190627-135642-766.png
20190627-135705-114.png
20190627-135727-574.png
20190627-135750-398.png
20190627-135813-619.png
20190627-135846-358.png
20190627-135919-806.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/8

20190627-134929-110.png
20190627-134953-378.png
20190627-135027-521.png
20190627-135051-175.png
20190627-135114-221.png
20190627-135140-484.png
20190627-135217-713.png
20190627-135241-012.png
20190627-135303-535.png
20190627-135326-888.png
20190627-135352-785.png
20190627-135418-942.png
20190627-135441-900.png
20190627-135506-797.png
20190627-135530-994.png
20190627-135554-926.png
20190627-135619-909.png
20190627-135644-434.png
20190627-135708-139.png
20190627-135731-743.png
20190627-135756-164.png
20190627-135821-486.png
20190627-135844-856.png
20190627-135908-539.png
20190627-135932-440.png
20190627-135957-424.png
20190627-140020-676.png
20190627-140046-348.png
20190627-140109-718.png
20190627-140134-611.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/23

20190627-135108-917.png
20190627-135130-847.png
20190627-135153-189.png
20190627-135216-082.png
20190627-135248-208.png
20190627-135309-839.png
20190627-135333-500.png
20190627-135356-022.png
20190627-135420-237.png
20190627-135441-539.png
20190627-135504-237.png
20190627-135527-028.png
20190627-135554-427.png
20190627-135620-942.png
20190627-135643-707.png
20190627-135706-055.png
20190627-135738-822.png
20190627-135800-817.png
20190627-135822-982.png
20190627-135844-729.png
20190627-135906-763.png
20190627-135928-382.png
20190627-135950-700.png
20190627-140011-950.png
20190627-140039-678.png
20190627-140108-380.png
20190627-140134-766.png
20190627-140204-794.png
20190627-140230-533.png
20190627-140259-064.png
20190627-140341-770.png
20190627-140428-186.png
20190627-140451-882.png
20190627-140514-408.png
20190627-140538-957.png
20190627-140601-755.png
20190627-140625-992.png
20190627-140654-293.png
20190627-140722-288.png
20190627-140744-897.png
20190627-140806-757.png
20190627-140827-549.png
20190627-140852-098.png
20190627-140918-088.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/24

20190627-135237-329.png
20190627-135259-871.png
20190627-135322-005.png
20190627-135344-523.png
20190627-135407-802.png
20190627-135430-812.png
20190627-135453-085.png
20190627-135515-353.png
20190627-135535-547.png
20190627-135557-461.png
20190627-135620-431.png
20190627-135642-782.png
20190627-135710-294.png
20190627-135738-007.png
20190627-135800-947.png
20190627-135824-311.png
20190627-135856-375.png
20190627-135917-259.png
20190627-135940-244.png
20190627-140001-612.png
20190627-140024-000.png
20190627-140045-900.png
20190627-140108-687.png
20190627-140130-827.png
20190627-140200-953.png
20190627-140231-708.png
20190627-140257-139.png
20190627-140324-950.png
20190627-140350-615.png
20190627-140427-602.png
20190627-140454-535.png
20190627-140520-164.png
20190627-140543-742.png
20190627-140605-084.png
20190627-140627-319.png
20190627-140649-995.png
20190627-140712-279.png
20190627-140734-578.png
20190627-140756-394.png
20190627-140819-827.png
20190627-140841-857.png
20190627-140903-236.png
20190627-140926-018.png
20190627-140948-222.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3596/5

20190627-135041-687.png
20190627-135107-560.png
20190627-135142-121.png
20190627-135206-074.png
20190627-135230-329.png
20190627-135254-195.png
20190627-135318-167.png
20190627-135343-307.png
20190627-135416-691.png
20190627-135440-229.png
20190627-135503-754.png
20190627-135527-261.png
20190627-135600-875.png
20190627-135624-907.png
20190627-135647-879.png
20190627-135713-235.png
20190627-135736-441.png
20190627-135759-538.png
20190627-135823-362.png
20190627-135846-651.png
20190627-135909-589.png
20190627-135933-164.png
20190627-135955-813.png
20190627-140030-523.png
20190627-140104-305.png
20190627-140126-926.png
20190627-140150-717.png
20190627-140215-609.png
20190627-140249-146.png
20190627-140314-622.png
20190627-140348-092.png
20190627-140412-119.png
20190627-140435-753.png
20190627-140458-874.png
20190627-140523-087.png
20190627-140548-551.png
20190627-140621-977.png
20190627-140644-735.png
20190627-140707-634.png
20190627-140730-970.png
20190627-140809-075.png
20190627-140837-733.png
20190627-140906-174.png
20190627-140934-514.png
20190627-141003-259.png
20190627-141031-958.png
20190627-141100-566.png
20190627-141128-900.png
20190627-141157-294.png
20190627-141225-033.png
20190627-141253-171.png
20190627-141321-141.png
20190627-141349-070.png
20190627-141427-097.png

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/prevent-whitespace-at-the-end-of-name branch from dbc5255 to 028bdbd Compare July 3, 2019 07:37
@DeepDiver1975
Copy link
Member

conflicts resolved ....

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/6

20190703-075344-896.png
20190703-075400-121.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/10

20190703-075526-147.png
20190703-075547-868.png
20190703-075612-049.png
20190703-075634-581.png
20190703-075657-179.png
20190703-075729-184.png
20190703-075751-624.png
20190703-075824-122.png
20190703-075845-649.png
20190703-075908-074.png
20190703-075929-746.png
20190703-075951-973.png
20190703-080014-075.png
20190703-080035-516.png
20190703-080107-350.png
20190703-080130-211.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/25

20190703-075330-364.png
20190703-075347-690.png
20190703-075404-930.png
20190703-075422-258.png
20190703-075439-542.png
20190703-075456-943.png
20190703-075514-750.png
20190703-075531-777.png
20190703-075548-867.png
20190703-075605-828.png
20190703-075622-871.png
20190703-075639-872.png
20190703-075659-602.png
20190703-075720-159.png
20190703-075737-277.png
20190703-075754-467.png
20190703-075811-693.png
20190703-075828-794.png
20190703-075845-910.png
20190703-075903-032.png
20190703-075919-997.png
20190703-075937-311.png
20190703-075954-386.png
20190703-080011-941.png
20190703-080032-370.png
20190703-080052-503.png
20190703-080111-467.png
20190703-080130-730.png
20190703-080149-790.png
20190703-080208-344.png
20190703-080226-805.png
20190703-080245-441.png
20190703-080302-687.png
20190703-080319-776.png
20190703-080336-857.png
20190703-080353-923.png
20190703-080410-948.png
20190703-080427-992.png
20190703-080445-113.png
20190703-080502-477.png
20190703-080519-777.png
20190703-080536-875.png
20190703-080554-179.png
20190703-080611-516.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/24

20190703-075326-717.png
20190703-075344-672.png
20190703-075401-800.png
20190703-075419-507.png
20190703-075436-853.png
20190703-075453-721.png
20190703-075510-883.png
20190703-075527-834.png
20190703-075545-626.png
20190703-075602-629.png
20190703-075622-896.png
20190703-075642-323.png
20190703-075704-686.png
20190703-075735-492.png
20190703-075758-895.png
20190703-075816-093.png
20190703-075835-303.png
20190703-075857-307.png
20190703-075917-772.png
20190703-075937-262.png
20190703-075956-824.png
20190703-080016-070.png
20190703-080036-146.png
20190703-080054-453.png
20190703-080114-799.png
20190703-080135-210.png
20190703-080153-898.png
20190703-080212-326.png
20190703-080231-787.png
20190703-080250-513.png
20190703-080308-768.png
20190703-080326-695.png
20190703-080344-308.png
20190703-080401-623.png
20190703-080419-054.png
20190703-080436-228.png
20190703-080453-617.png
20190703-080510-516.png
20190703-080527-547.png
20190703-080545-371.png
20190703-080603-110.png
20190703-080620-400.png
20190703-080637-621.png
20190703-080655-258.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/9

20190703-075505-519.png
20190703-075529-243.png
20190703-075553-111.png
20190703-075615-889.png
20190703-075648-800.png
20190703-075711-605.png
20190703-075734-829.png
20190703-075757-045.png
20190703-075819-503.png
20190703-075841-938.png
20190703-075904-513.png
20190703-075926-611.png
20190703-075948-817.png
20190703-080011-323.png
20190703-080038-201.png
20190703-080100-838.png
20190703-080134-061.png
20190703-080206-126.png
20190703-080228-652.png
20190703-080251-091.png
20190703-080313-567.png
20190703-080336-061.png
20190703-080357-970.png
20190703-080420-262.png
20190703-080442-124.png
20190703-080514-482.png
20190703-080537-394.png
20190703-080600-214.png
20190703-080622-426.png
20190703-080655-536.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3712/5

20190703-075420-871.png
20190703-075443-453.png
20190703-075506-461.png
20190703-075527-018.png
20190703-075547-743.png
20190703-075608-312.png
20190703-075642-229.png
20190703-075703-593.png
20190703-075735-668.png
20190703-075756-244.png
20190703-075817-383.png
20190703-075839-435.png
20190703-075901-935.png
20190703-075924-700.png
20190703-075946-842.png
20190703-080018-926.png
20190703-080042-748.png
20190703-080102-859.png
20190703-080123-978.png
20190703-080144-987.png
20190703-080205-712.png
20190703-080226-745.png
20190703-080247-173.png
20190703-080307-989.png
20190703-080329-194.png
20190703-080354-544.png
20190703-080415-929.png
20190703-080441-131.png
20190703-080501-641.png
20190703-080522-112.png
20190703-080542-811.png
20190703-080602-883.png
20190703-080623-194.png
20190703-080643-872.png
20190703-080704-799.png
20190703-080725-074.png
20190703-080745-894.png
20190703-080806-258.png
20190703-080826-709.png
20190703-080847-286.png
20190703-080911-904.png
20190703-080936-941.png
20190703-081002-297.png
20190703-081026-912.png
20190703-081052-105.png
20190703-081116-990.png
20190703-081143-627.png
20190703-081209-433.png
20190703-081235-234.png
20190703-081300-869.png
20190703-081325-494.png
20190703-081350-949.png
20190703-081415-567.png
20190703-081441-557.png

@LukasHirt
Copy link
Collaborator Author

@DeepDiver1975 Tests failed due to timeout... Can you try restarting them?

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/prevent-whitespace-at-the-end-of-name branch from 028bdbd to 482345e Compare July 4, 2019 15:20
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUILogin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/6

20190704-152855-758.png
20190704-152910-734.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUINotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/8

20190704-152919-905.png
20190704-152936-597.png
20190704-152953-338.png
20190704-153009-942.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/14

20190704-152914-842.png
20190704-152934-134.png
20190704-152953-229.png
20190704-153011-812.png
20190704-153030-502.png
20190704-153049-688.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/15

20190704-152930-586.png
20190704-152948-884.png
20190704-153007-011.png
20190704-153025-145.png
20190704-153042-564.png
20190704-153110-109.png
20190704-153127-763.png
20190704-153145-479.png
20190704-153205-450.png
20190704-153225-444.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/10

20190704-152849-091.png
20190704-152905-743.png
20190704-152922-350.png
20190704-152938-796.png
20190704-152955-396.png
20190704-153011-915.png
20190704-153028-191.png
20190704-153044-769.png
20190704-153101-503.png
20190704-153118-103.png
20190704-153134-573.png
20190704-153151-106.png
20190704-153207-579.png
20190704-153223-945.png
20190704-153240-254.png
20190704-153256-877.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFavorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/4

20190704-152914-566.png
20190704-152932-256.png
20190704-152949-698.png
20190704-153006-937.png
20190704-153024-071.png
20190704-153041-402.png
20190704-153058-652.png
20190704-153115-884.png
20190704-153133-246.png
20190704-153150-705.png
20190704-153208-060.png
20190704-153225-725.png
20190704-153243-039.png
20190704-153300-324.png
20190704-153317-642.png
20190704-153335-078.png
20190704-153352-584.png
20190704-153409-893.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIUpload failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/20

20190704-152946-309.png
20190704-153002-555.png
20190704-153018-643.png
20190704-153034-525.png
20190704-153050-482.png
20190704-153106-562.png
20190704-153122-636.png
20190704-153138-666.png
20190704-153154-548.png
20190704-153210-411.png
20190704-153226-360.png
20190704-153242-334.png
20190704-153258-384.png
20190704-153314-346.png
20190704-153330-430.png
20190704-153346-618.png
20190704-153402-877.png
20190704-153418-823.png
20190704-153434-819.png
20190704-153450-849.png
20190704-153506-764.png
20190704-153523-021.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/9

20190704-152943-128.png
20190704-153006-459.png
20190704-153023-505.png
20190704-153040-463.png
20190704-153057-036.png
20190704-153113-782.png
20190704-153130-432.png
20190704-153147-110.png
20190704-153203-931.png
20190704-153220-810.png
20190704-153237-529.png
20190704-153253-968.png
20190704-153310-736.png
20190704-153327-175.png
20190704-153343-767.png
20190704-153400-409.png
20190704-153417-234.png
20190704-153434-040.png
20190704-153450-732.png
20190704-153507-865.png
20190704-153524-461.png
20190704-153541-266.png
20190704-153558-156.png
20190704-153614-685.png
20190704-153631-211.png
20190704-153647-704.png
20190704-153704-561.png
20190704-153721-134.png
20190704-153737-700.png
20190704-153754-344.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/25

20190704-152928-926.png
20190704-152944-586.png
20190704-153000-270.png
20190704-153015-898.png
20190704-153031-547.png
20190704-153047-082.png
20190704-153102-563.png
20190704-153118-146.png
20190704-153133-797.png
20190704-153149-289.png
20190704-153204-978.png
20190704-153220-544.png
20190704-153238-555.png
20190704-153256-715.png
20190704-153312-461.png
20190704-153328-068.png
20190704-153343-466.png
20190704-153358-835.png
20190704-153414-365.png
20190704-153429-979.png
20190704-153445-537.png
20190704-153500-901.png
20190704-153516-440.png
20190704-153531-903.png
20190704-153550-094.png
20190704-153608-556.png
20190704-153625-609.png
20190704-153642-620.png
20190704-153659-515.png
20190704-153716-809.png
20190704-153733-492.png
20190704-153750-228.png
20190704-153805-717.png
20190704-153821-218.png
20190704-153836-785.png
20190704-153852-186.png
20190704-153907-710.png
20190704-153923-225.png
20190704-153938-564.png
20190704-153954-027.png
20190704-154009-503.png
20190704-154025-048.png
20190704-154040-635.png
20190704-154056-289.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/24

20190704-152924-141.png
20190704-152940-063.png
20190704-152955-753.png
20190704-153011-436.png
20190704-153026-928.png
20190704-153042-603.png
20190704-153058-272.png
20190704-153113-986.png
20190704-153129-881.png
20190704-153145-571.png
20190704-153201-419.png
20190704-153217-149.png
20190704-153235-335.png
20190704-153253-538.png
20190704-153309-352.png
20190704-153324-879.png
20190704-153340-521.png
20190704-153356-120.png
20190704-153412-125.png
20190704-153427-692.png
20190704-153443-315.png
20190704-153458-751.png
20190704-153514-460.png
20190704-153529-991.png
20190704-153548-307.png
20190704-153606-703.png
20190704-153624-007.png
20190704-153641-246.png
20190704-153658-174.png
20190704-153715-192.png
20190704-153731-813.png
20190704-153748-374.png
20190704-153803-986.png
20190704-153820-041.png
20190704-153835-764.png
20190704-153851-363.png
20190704-153917-105.png
20190704-153932-911.png
20190704-153948-697.png
20190704-154004-451.png
20190704-154020-025.png
20190704-154035-577.png
20190704-154051-215.png
20190704-154107-014.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3788/5

20190704-152918-032.png
20190704-152934-899.png
20190704-152951-655.png
20190704-153008-798.png
20190704-153025-512.png
20190704-153042-198.png
20190704-153058-915.png
20190704-153115-506.png
20190704-153132-441.png
20190704-153148-669.png
20190704-153205-203.png
20190704-153221-722.png
20190704-153238-486.png
20190704-153255-033.png
20190704-153311-401.png
20190704-153328-350.png
20190704-153344-881.png
20190704-153401-582.png
20190704-153418-378.png
20190704-153435-000.png
20190704-153451-530.png
20190704-153508-097.png
20190704-153524-580.png
20190704-153541-097.png
20190704-153557-986.png
20190704-153614-867.png
20190704-153631-579.png
20190704-153648-388.png
20190704-153705-101.png
20190704-153721-801.png
20190704-153738-554.png
20190704-153805-111.png
20190704-153821-919.png
20190704-153838-612.png
20190704-153855-032.png
20190704-153911-637.png
20190704-153928-258.png
20190704-153944-780.png
20190704-154001-053.png
20190704-154017-779.png
20190704-154037-122.png
20190704-154056-356.png
20190704-154115-557.png
20190704-154135-130.png
20190704-154154-143.png
20190704-154213-112.png
20190704-154232-342.png
20190704-154251-099.png
20190704-154312-122.png
20190704-154332-541.png
20190704-154352-042.png
20190704-154411-308.png
20190704-154430-300.png
20190704-154449-819.png

@LukasHirt LukasHirt force-pushed the bugfix/prevent-whitespace-at-the-end-of-name branch from 482345e to a54f935 Compare July 5, 2019 08:44
@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3809/25

20190705-084947-319.png
20190705-084947-414.png
20190705-084947-473.png
20190705-084947-536.png
20190705-085006-668.png
20190705-085006-729.png
20190705-085006-802.png
20190705-085006-892.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3809/5

20190705-085148-096.png
20190705-085148-304.png
20190705-085148-549.png
20190705-085148-755.png
20190705-085210-928.png
20190705-085211-127.png
20190705-085211-327.png
20190705-085211-543.png
20190705-085234-498.png
20190705-085234-718.png
20190705-085234-925.png
20190705-085235-149.png
20190705-085306-929.png
20190705-085307-149.png
20190705-085307-362.png
20190705-085307-565.png
20190705-085326-795.png
20190705-085327-003.png
20190705-085327-194.png
20190705-085327-421.png
20190705-085348-960.png
20190705-085349-186.png
20190705-085349-383.png
20190705-085349-590.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/3809/24

20190705-085047-398.png
20190705-085047-535.png
20190705-085047-681.png
20190705-085047-809.png
20190705-085109-544.png
20190705-085109-691.png
20190705-085109-831.png
20190705-085109-952.png

@DeepDiver1975
Copy link
Member

PR from hell 🤯

@LukasHirt LukasHirt force-pushed the bugfix/prevent-whitespace-at-the-end-of-name branch from 9fa15f3 to 6232625 Compare July 5, 2019 12:04
@LukasHirt
Copy link
Collaborator Author

@DeepDiver1975 Finally green! 🎆 Merging now 😉

@LukasHirt LukasHirt merged commit 35e917b into master Jul 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/prevent-whitespace-at-the-end-of-name branch July 6, 2019 14:33
@dschmidt dschmidt mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasHirt @ownclouders @DeepDiver1975