Fixed actions in notifications #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
requested changes
Aug 6, 2019
src/components/Notifications.vue
Outdated
| routeName: this.$route.name | ||
| }).catch((error) => { | ||
| this.showMessage({ | ||
| title: this.$gettext('Loading folder failed'), |
There was a problem hiding this comment.
Please copy texts to make sure we have them consistent and reduce the amount of translations - THX
Added reload of list Fixed error title
LukasHirt
force-pushed
the
feature/pending-shares
branch
from
73e04c9
to
5f3410f
Compare
DeepDiver1975
approved these changes
Aug 6, 2019
💥 Acceptance tests webUITrashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/4567/10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed sort of actions, replaced buttons with oc-button component and added reload action for files list.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: