Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test sharing a file via public link #1981

Merged
merged 1 commit into from
Sep 18, 2019
Merged

test sharing a file via public link #1981

merged 1 commit into from
Sep 18, 2019

Conversation

individual-it
Copy link
Member

Description

test sharing also just a single file via public link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it self-assigned this Sep 16, 2019
PVince81
PVince81 approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine to me

I guess we'll want to adopt this pattern in more places ? Last week I saw many places where we still need to write down "file" and "folder"

@individual-it
Copy link
Member Author

@PVince81 I think "resource" is the term @pmaier1 introduces as the "official"
for these tests its just an alias, and any file/folder/resource can be used without any effect https://github.com/owncloud/phoenix/blob/master/tests/acceptance/stepDefinitions/publicLinkContext.js#L10

haribhandari07
haribhandari07 reviewed Sep 16, 2019
View reviewed changes
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit bf6fa85 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the testPublicLinkFile branch September 18, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haribhandari07 haribhandari07 haribhandari07 left review comments

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@individual-it individual-it

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @PVince81 @haribhandari07