Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set X-Requested-With header - required ownCloud 10.3 #1984

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 16, 2019

Description

Any request sent from phoenix to ownCloud has to include the header X-Requested-With
This is necessary to prevent browsers to popup an authentication dialog on a 401 response

This will only work with ownCloud 10.3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 self-assigned this Sep 16, 2019
@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Sep 16, 2019
@PVince81
Copy link
Contributor

Restarted CI jobs. Somehow some were marked cancelled.

@LukasHirt
Copy link
Collaborator

Restarted CI jobs. Somehow some were marked cancelled.

Failing also in some other places. Going over the "1 hour" limit for tasks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants