Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public link permissions mix up #1985

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Fix public link permissions mix up #1985

merged 2 commits into from
Sep 18, 2019

Conversation

PVince81
Copy link
Contributor

Description

The permissions for Editor and Contributor got mixed up.
This swaps them.

Related Issue

Fixes #1979

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Notes

Test will come separately in #1980

@PVince81 PVince81 added the Status:Needs-Review Needs review from a maintainer label Sep 16, 2019
@PVince81 PVince81 self-assigned this Sep 16, 2019
This was referenced Sep 16, 2019
Closed
Closed
@PVince81
Copy link
Contributor Author

@individual-it feel free to cherry-pick your tests in this PR

Vincent Petry and others added 2 commits September 18, 2019 07:41
@individual-it
Fix public link permissions mix up
301c456 
The permissions for Editor and Contributor got mixed up.
This swaps them.
@individual-it
test public links with different permissions
26f5ac9
@individual-it
Copy link
Member

rebased and added tests

@individual-it
Copy link
Member

all tests pass but CI failed
image

restarted

LukasHirt
LukasHirt approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 If @individual-it is okay with tests let's merge it

@individual-it individual-it merged commit 3701d06 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/public-link-perms-mix-up branch September 18, 2019 09:16
@phil-davis phil-davis mentioned this pull request Oct 4, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@LukasHirt LukasHirt LukasHirt approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

permission / description missmatch for public links
3 participants
@PVince81 @individual-it @LukasHirt