Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade vuex-persist to 2.0.1 to fix IE11 issues #2007

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Downgrade vuex-persist to 2.0.1 to fix IE11 issues #2007

merged 1 commit into from
Sep 18, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 18, 2019 •
edited
Loading

Description

See championswimmer/vuex-persist#138 - 2.1.0 is not working in IE11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Sep 18, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 18, 2019
LukasHirt
LukasHirt approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@LukasHirt
Copy link
Contributor

Tests again failed due to timeout. Restarting

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5132/

20190918-092129-106.png
20190918-092151-120.png
20190918-092211-125.png
20190918-092232-668.png
20190918-092254-240.png
20190918-092315-659.png
20190918-092347-093.png
20190918-092408-537.png
20190918-092429-732.png
20190918-092451-398.png
20190918-092523-161.png
20190918-092545-188.png
20190918-092606-597.png
20190918-092627-797.png
20190918-092649-451.png
20190918-092711-731.png
20190918-092732-490.png
20190918-092806-220.png
20190918-092827-262.png
20190918-092847-479.png
20190918-092908-083.png
20190918-092928-175.png
20190918-092949-912.png
20190918-093023-146.png
20190918-093044-645.png
20190918-093105-069.png
20190918-093136-511.png
20190918-093158-353.png
20190918-093222-011.png
20190918-093242-931.png
20190918-093304-864.png
20190918-093336-917.png
20190918-093358-101.png
20190918-093420-677.png
20190918-093444-761.png
20190918-093506-495.png
20190918-093527-343.png
20190918-093547-478.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5134/

20190918-113037-507.png
20190918-113106-271.png

@DeepDiver1975 DeepDiver1975 merged commit 3e3c845 into master Sep 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/downgrade-vuex-persist branch September 18, 2019 13:57
@hoophony
Copy link

@DeepDiver1975 I changed the version to 2.0.1, but the issues still exists in ie about "unable to get undefined or null referenced property "toLowerCase""

@DeepDiver1975
Copy link
Member Author

Since this pr is merged you can simply build Phoenix from master branch now

@hoophony
Copy link

@DeepDiver1975 Thank you very much,I have solved the problem after deleting the file named .cache in node_modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepDiver1975 @LukasHirt @ownclouders @hoophony