Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of auth errors (access denied, invalid token or cannot refres… #2079

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Sep 26, 2019

Description

In case of auth errors (access denied, invalid token or cannot refresh token) the state is cleared - otherwise there is no way to get out of this

How Has This Been Tested?

  • login via oauth to owncloud
  • wait until the token times out (30min afaik)
  • access denied page pops up
  • go back to login page
  • login page shall appear (without this patch the accessDenied page will show up)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

…h token) the state is cleared - otherwise there is no way to get out of this
@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Sep 26, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 26, 2019
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code makes sense

would it be possible to add acceptance tests ? (separate PR is fine, raise a ticket)

@PVince81
Copy link
Contributor

I happened to be stuck in such loop so I checked out this branch and the problem went away 👍

@PVince81 PVince81 merged commit f03a654 into master Sep 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/clean-state-on-auth-error branch September 27, 2019 08:08
@PVince81
Copy link
Contributor

@DeepDiver1975 please evaluate if acceptance testing is possible and if yes raise a ticket for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants