Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of public pages despite existing auth #2097

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Fix detection of public pages despite existing auth #2097

merged 1 commit into from
Sep 30, 2019

Conversation

PVince81
Copy link
Contributor

Description

When opening public links while a session exists, we should still
consider the page a public page whenever the route is not requiring
auth. The latter is the case for public files and files drop pages.

Related Issue

Fixes #1884

Motivation and Context

How Has This Been Tested?

  • TEST: access public link while authentication exists and delete a file must work
  • TEST: access public link while no authentication exists and delete a file must work
  • TEST: smoke test regular file list while authenticated

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Fix detection of public pages
0179187 
When opening public links while a session exists, we should still
consider the page a public page whenever the route is not requiring
auth. The latter is the case for public files and files drop pages.
@PVince81 PVince81 added Status:Needs-Review Needs review from a maintainer Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 30, 2019
@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Sep 30, 2019
@PVince81 PVince81 self-assigned this Sep 30, 2019
@PVince81 PVince81 mentioned this pull request Sep 30, 2019
Closed
@LukasHirt LukasHirt merged commit 750d2f0 into master Sep 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/refine-public-page-check branch September 30, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

public link does not work correctly when accessed by an logged-in user
2 participants
@PVince81 @LukasHirt