Fix public link access in incognito mode #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
reviewed
Oct 1, 2019
💥 Acceptance tests failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5359/
|
added 2 commits
October 1, 2019 13:59
Fixes public link page access when no session ever existed or with incognito mode.
PVince81
force-pushed
the
bugfix/public-link-incognito
branch
from
e265a79
to
eecc0ce
Compare
|
@LukasHirt rebased after merging the deps PR and adjusted, please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes public link page access when no session ever existed or with incognito mode.
Related Issue
Fixes #1882
Motivation and Context
How Has This Been Tested?
Manual test.
This will be covered also when tests for public page get added through #1951
Screenshots (if appropriate):
Types of changes
Checklist: