Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send header X-Requested-With: XMLHttpRequest in all requests #2197

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Send header X-Requested-With: XMLHttpRequest in all requests #2197

merged 1 commit into from
Oct 9, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 9, 2019 •
edited
Loading

Description

All requests must contain the header X-Requested-With: XMLHttpRequest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Oct 9, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 9, 2019
LukasHirt
LukasHirt approved these changes Oct 9, 2019
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have it in store so we don't have to specify it at so many different places. But let's do this in some later PR.

@DeepDiver1975
Copy link
Member Author

Would be nice to have it in store so we don't have to specify it at so many different places. But let's do this in some later PR.

these calls all need to go into the sdk ....

@DeepDiver1975 DeepDiver1975 merged commit 91f6e14 into master Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/avatar-x-requested-with branch October 9, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @LukasHirt