Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate token refresh calls #2205

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Prevent duplicate token refresh calls #2205

merged 1 commit into from
Oct 10, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 10, 2019 •
edited
Loading

Description

Due to programming error two token refresh calls are issued to the IdP.
This is fixed now and more logging information is written to the console.

How Has This Been Tested?

  • to test with a true OpenId Connect IdP - e.g. PingId

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Oct 10, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 10, 2019
LukasHirt
LukasHirt approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 0f98f59 into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/openid-refresh-flow branch October 10, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DeepDiver1975 @LukasHirt