Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to show instead of if in upload progress bar #2206

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Switch to show instead of if in upload progress bar #2206

merged 1 commit into from
Oct 10, 2019

Conversation

LukasHirt
Copy link
Collaborator

Description

With v-if were an issue in displaying the progress bar too late.

How Has This Been Tested?

  • test environment: Manually
  1. Upload a folder

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added the Status:Needs-Review Needs review from a maintainer label Oct 10, 2019
@LukasHirt LukasHirt self-assigned this Oct 10, 2019
@DeepDiver1975 DeepDiver1975 merged commit 7c60fd2 into master Oct 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/progress-bar branch October 10, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @DeepDiver1975