Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change key of file action buttons to ariaLabel #2219

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Change key of file action buttons to ariaLabel #2219

merged 1 commit into from
Oct 14, 2019

Conversation

LukasHirt
Copy link
Contributor

Motivation and Context

Using index as a key can cause troubles with rendering of elements.

How Has This Been Tested?

  • test environment: Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer Type:Technical-Debt labels Oct 11, 2019
@LukasHirt LukasHirt self-assigned this Oct 11, 2019
PVince81
PVince81 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 3f3b9bc into master Oct 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/actions-keys branch October 14, 2019 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@Julian1998 Julian1998 Awaiting requested review from Julian1998

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer Type:Technical-Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @PVince81