Trigger add to progress before the folders creation #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Strange that you get two slashes there... |
also fails on master for me 🙈 |
I tried it also on phoenix.owncloud.com and works for me there and locally as well. |
|
Anyway, I get also folder "a" and "b" into the folder where I triggered the upload. I'll debug this. |
💥 Acceptance tests webUIFiles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/5633/
|
|
Fix for the issue with upload of subfolders - #2224 |
DeepDiver1975
approved these changes
Oct 14, 2019
delete-merged-branch
bot
deleted the
bugfix/add-files-to-queue-before-folder-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move addToProgress into its own function and trigger it before the folders creation.
Motivation and Context
Since we wait until all folders are created and those promises are being processed one by one it would take quite some time before the actual progress bar is shown. This takes care of that. We need to figure out though how to handle if some specific folder fails.
How Has This Been Tested?
Types of changes
Checklist: