Handle remove from progress in its own mutation #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
reviewed
Oct 14, 2019
| const promise = new Promise((resolve, reject) => { | ||
| xhr.onload = e => { | ||
| xhr.status >= 200 && xhr.status < 400 ? resolve(e) : reject(new Error(xhr.statusText)) | ||
| } | ||
| xhr.onloadend = e => { |
There was a problem hiding this comment.
is this polyfilled for IE and co ? see https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onloadend
There was a problem hiding this comment.
AFAIK using onload should be enough here ?
There was a problem hiding this comment.
Tested it in ie11 (Win 7) - works.
The good thing about onloadend is that it's triggered also in case it failed.
There was a problem hiding this comment.
ok, so if it works it means we have a polyfill in place.
note that chrome also doesn't support this property, mind testing there as well ?
There was a problem hiding this comment.
Already tested. Works in IE11, FF, chrome, safari and edge.
LukasHirt
force-pushed
the
bugfix/remove-from-progress
branch
from
0dd6023
to
a0c9ed4
Compare
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move remove from progress into its own method, use id instead of name to find the right progress and call the action on requests loadend event.
How Has This Been Tested?
Types of changes
Checklist: