Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong method for copy action of public link #2363

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Fixed wrong method for copy action of public link #2363

merged 1 commit into from
Nov 5, 2019

Conversation

LukasHirt
Copy link
Collaborator

Description

Replaced method for copying the public link from old package to the new one.

How Has This Been Tested?

  • test environment: Manually
  1. Create public link
  2. Copy the link with the clipboard icon
  3. Navigate to the public link

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@LukasHirt LukasHirt added Status:Needs-Review Needs review from a maintainer bug-solved labels Nov 4, 2019
@LukasHirt LukasHirt self-assigned this Nov 4, 2019
PVince81
PVince81 approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

let the CI fight continue...

@PVince81
Copy link
Contributor

PVince81 commented Nov 5, 2019

npm install failed in CI, restarted...

@LukasHirt LukasHirt merged commit 753995b into master Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/public-link-copy branch November 5, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@LukasHirt LukasHirt

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @PVince81