group sharing acceptance tests #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haribhandari07
added
Status:Needs-Review
dpakach
reviewed
Nov 6, 2019
| @@ -32,3 +32,31 @@ Feature: Sharing files and folders with internal groups | |||
| | group | | |||
| | ?\?@#%@,; | | |||
| | नेपाली | | |||
|
|
|||
| Scenario: Share file with a user and a group with same name | |||
There was a problem hiding this comment.
I think we can add more scenarios like this. Similar tests were recently added in core. Please check them for reference.
owncloud/core#36283
haribhandari07
force-pushed
the
group-sharing
branch
3 times, most recently
from
f743f17
to
ca70689
Compare
haribhandari07
force-pushed
the
group-sharing
branch
from
ca70689
to
0c7feae
Compare
💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6310/
|
💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/phoenix/6310/
|
haribhandari07
force-pushed
the
group-sharing
branch
from
0c7feae
to
bca1090
Compare
dpakach
reviewed
Nov 13, 2019
haribhandari07
force-pushed
the
group-sharing
branch
from
bca1090
to
85e166e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds acceptance tests for group sharing.
How Has This Been Tested?
CI
Screenshots (if appropriate):
Types of changes
Checklist: