Refactor filesPage page-object for assertion management #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranparajuli589
added
Status:Needs-Review
kiranparajuli589
requested review from
jasson99,
haribhandari07,
skshetry and
dpakach
dpakach
reviewed
Dec 6, 2019
| .waitForElementVisible('@versionsList') | ||
| .api.elements('xpath', this.elements.versionsList.selector, function (result) { | ||
| assert.strictEqual(expectedNumber, result.value.length) | ||
| isVersionsPresent: async function () { |
There was a problem hiding this comment.
Suggested change
| isVersionsPresent: async function () { | |
| getVersionsCount: async function () { |
|
LGTM 👍 |
skshetry
reviewed
Dec 9, 2019
| .api.elements('xpath', this.elements.versionsList.selector, function (result) { | ||
| assert.strictEqual(expectedNumber, result.value.length) | ||
| getVersionsCount: async function () { | ||
| let count |
There was a problem hiding this comment.
Suggested change
| let count | |
| let count = 0 |
Comment on lines
326
to
327
| this.elements.versionsList.locateStrategy, | ||
| this.elements.versionsList.selector, |
There was a problem hiding this comment.
if possible use this.elements('@versionsList')
There was a problem hiding this comment.
absolutely possible!
🚀
|
alright just fix pending changes requests |
kiranparajuli589
requested review from
skshetry,
jasson99 and
haribhandari07
and removed request for
jasson99
kiranparajuli589
force-pushed
the
assertion-refactor-files-page
branch
from
1ac5d64
to
5ff7d3b
Compare
kiranparajuli589
force-pushed
the
assertion-refactor-files-page
branch
from
5ff7d3b
to
51cf9c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the assertions from filesPage
page-objectsare moved torespective contexts.Related Issue
Motivation and Context
Better Code = Life GooD
How Has This Been Tested?
CI
Checklist: