Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aspects of share flow accessibility #2622

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Fix aspects of share flow accessibility #2622

merged 1 commit into from
Dec 17, 2019

Conversation

marcus-herrmann
Copy link
Contributor

Regarding: Buttons, autocomplete, hidden panels in tab

Description

  • Make controls regarding contributor actions proper buttons
  • Improve autocomplete
  • Prevent getting keyboard focus into hidden part of the "Collaborators" tab

Related Issue

Dependencies to other tickets

Motivation and Context

The share flow was one particular user flow suffering from poor keyboard and screen reader accessibility.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@marcus-herrmann
Fix aspects of share flow accessibility
4634adf 
Buttons, autocomplete, hidden panels in tab
@marcus-herrmann marcus-herrmann self-assigned this Dec 6, 2019
@marcus-herrmann marcus-herrmann mentioned this pull request Dec 6, 2019
Closed
PVince81
PVince81 approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit ea56555 into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/acessible-share-flow branch December 17, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@marcus-herrmann marcus-herrmann

Labels
Status:Needs-Review Needs review from a maintainer Topic:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccessible share flow
2 participants
@marcus-herrmann @PVince81