File actions can be defined using config settings #2651

DeepDiver1975 · 2019-12-09T11:30:12Z

Description

Prototype to show how #2573 could work

For the file action POC please add this json snippet to config.json

  "files": {
     // ....
    "actions": [
      {
          "icon": "/documents/office.svg",
          "url": "/documents/edit/{PATH}",
          "title": {
              "en": "Edit in Awesome Office™",
              "de": "Mit Awesome Office™ bearbeiten"
          },
          "extensions": [
            "docx", "xlsx"
          ]
      },
      {
        "icon": "/office365/office.svg",
        "url": "/office365/edit/{FILEID}",
        "title": {
            "en": "Edit in Office 365™",
            "de": "Mit Office 365™ bearbeiten"
        },
        "extensions": [
          "docx", "xlsx"
        ]
    }
  ]

Related Issue

#2573

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):

Now with external svg icon:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

ownclouders · 2019-12-09T13:21:46Z

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7050/

ownclouders · 2019-12-09T13:30:51Z

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7050/

ownclouders · 2019-12-09T13:47:40Z

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7050/

ownclouders · 2019-12-09T13:57:02Z

💥 Acceptance tests Files failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7050/

ownclouders · 2019-12-09T21:15:11Z

💥 Acceptance tests Notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:15:17Z

💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:16:50Z

💥 Acceptance tests Login failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:19:41Z

💥 Acceptance tests Account failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:20:15Z

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:20:53Z

💥 Acceptance tests SharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

ownclouders · 2019-12-09T21:23:11Z

💥 Acceptance tests RestrictSharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7055/

PVince81 · 2019-12-10T08:28:57Z

apps/files/src/default.js

@@ -22,6 +22,7 @@ const appInfo = {
  icon: 'folder',
  isFileEditor: false,
  extensions: [],
+  fileActions: window.phoenixConfig.files.actions,


accessing the window object here feels a bit hacky.

it should be possible to inject the config by adjusting this file to be a big function(phoenixConfig) that returns the objects that we currently return in the default export.

the caller should then detect if we returned a function, if yes call it with injection. else assume it's an object

(and I wonder if this will stay relevant once we switch to a separate phoenix-files app)

(and I wonder if this will stay relevant once we switch to a separate phoenix-files app)

I dont think so .... initialization of code like this will happen in a vue component and the config is living in the store then.

So from my pov this is an acceptable work around for the time being.

DeepDiver1975 · 2019-12-10T13:32:28Z

furthermore: I have no damn clue why ci is failing ....

skshetry · 2019-12-11T08:41:44Z

@DeepDiver1975, The page is empty and is throwing the following error in console. Probably, actions has to be mentioned in the config.

files.bundle.js:28 Uncaught TypeError: Cannot read property 'actions' of undefined
    at Module.<anonymous> (files.bundle.js:28)
    at i (files.bundle.js:1)
    at files.bundle.js:1
    at files.bundle.js:1
phoenix.js:93 Uncaught TypeError: Cannot read property 'appInfo' of undefined
    at _loop (phoenix.js:93)
    at loadApps (phoenix.js:92)
    at Object.execCb (require.js:1696)
    at Module.check (require.js:883)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)

ownclouders · 2019-12-11T08:59:50Z

💥 Acceptance tests PrivateLinks failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T08:59:54Z

💥 Acceptance tests Notifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T09:02:08Z

💥 Acceptance tests Login failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T09:02:16Z

💥 Acceptance tests Account failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T09:04:27Z

💥 Acceptance tests SharingNotifications failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T09:05:13Z

💥 Acceptance tests SharingExternal failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

ownclouders · 2019-12-11T09:08:01Z

💥 Acceptance tests SharingFilePermissionsGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7090/

DeepDiver1975 · 2019-12-11T09:09:39Z

@DeepDiver1975, The page is empty and is throwing the following error in console. Probably, actions has to be mentioned in the config.

files.bundle.js:28 Uncaught TypeError: Cannot read property 'actions' of undefined
    at Module.<anonymous> (files.bundle.js:28)
    at i (files.bundle.js:1)
    at files.bundle.js:1
    at files.bundle.js:1
phoenix.js:93 Uncaught TypeError: Cannot read property 'appInfo' of undefined
    at _loop (phoenix.js:93)
    at loadApps (phoenix.js:92)
    at Object.execCb (require.js:1696)
    at Module.check (require.js:883)
    at Module.<anonymous> (require.js:1139)
    at require.js:134
    at require.js:1189
    at each (require.js:59)
    at Module.emit (require.js:1188)
    at Module.check (require.js:938)

THX a lot @skshetry - it is really a pity that we don't see such errors in drone anywhere ....

ownclouders · 2019-12-12T08:24:22Z

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7125/

ownclouders · 2019-12-12T08:28:38Z

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7125/

ownclouders · 2019-12-12T08:29:33Z

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7125/

ownclouders · 2019-12-12T08:30:16Z

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7125/

ownclouders · 2019-12-12T08:31:01Z

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7125/

ownclouders · 2019-12-12T10:03:29Z

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7129/

ownclouders · 2019-12-12T10:04:52Z

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7129/

ownclouders · 2019-12-12T10:05:34Z

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7129/

ownclouders · 2019-12-12T10:15:15Z

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7129/

ownclouders · 2019-12-12T10:17:35Z

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7129/

DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Dec 9, 2019

DeepDiver1975 requested a review from PVince81 December 9, 2019 11:30

DeepDiver1975 self-assigned this Dec 9, 2019

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from 8de4356 to b8f2887 Compare December 9, 2019 11:52

PVince81 reviewed Dec 10, 2019

View reviewed changes

DeepDiver1975 mentioned this pull request Dec 10, 2019

Files sidebars can now be loaded as Web Components via the config file #2584

Merged

10 tasks

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from b8f2887 to db3f64d Compare December 11, 2019 08:49

owncloud deleted a comment from ownclouders Dec 11, 2019

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from db3f64d to 4d235dd Compare December 11, 2019 09:08

PVince81 mentioned this pull request Dec 11, 2019

oc-icon shall optionally take a url from where to load the svg to be used owncloud/owncloud-design-system#562

Closed

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from 4d235dd to 55444a9 Compare December 12, 2019 08:03

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from 55444a9 to c9985e8 Compare December 16, 2019 08:40

File actions can be defined using config settings

96fca1f

DeepDiver1975 force-pushed the feature/file-actions-from-config branch from c9985e8 to 96fca1f Compare December 17, 2019 08:12

PVince81 approved these changes Dec 17, 2019

View reviewed changes

DeepDiver1975 merged commit fe7018b into master Dec 17, 2019

delete-merged-branch bot deleted the feature/file-actions-from-config branch December 17, 2019 09:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

File actions can be defined using config settings #2651

File actions can be defined using config settings #2651

DeepDiver1975 commented Dec 9, 2019 •

edited

Loading

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

PVince81 Dec 10, 2019

DeepDiver1975 Dec 10, 2019

DeepDiver1975 commented Dec 10, 2019

skshetry commented Dec 11, 2019 •

edited

Loading

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

DeepDiver1975 commented Dec 11, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

File actions can be defined using config settings #2651

File actions can be defined using config settings #2651

Conversation

DeepDiver1975 commented Dec 9, 2019 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

ownclouders commented Dec 9, 2019

PVince81 Dec 10, 2019

Choose a reason for hiding this comment

DeepDiver1975 Dec 10, 2019

Choose a reason for hiding this comment

DeepDiver1975 commented Dec 10, 2019

skshetry commented Dec 11, 2019 • edited Loading

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

ownclouders commented Dec 11, 2019

DeepDiver1975 commented Dec 11, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

ownclouders commented Dec 12, 2019

DeepDiver1975 commented Dec 9, 2019 •

edited

Loading

skshetry commented Dec 11, 2019 •

edited

Loading