Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/no checkbox label in files list #2680

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Bugfix/no checkbox label in files list #2680

merged 2 commits into from
Dec 12, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Dec 12, 2019 •
edited
Loading

Description

Fixing labels on checkboxes in file list

Screenshot from 2019-12-12 08-56-49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Dec 12, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Dec 12, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7131/

20191212-112218-826.png
20191212-112306-308.png
20191212-112416-178.png
20191212-112501-116.png
20191212-112548-579.png
20191212-112636-579.png
20191212-112722-579.png
20191212-112827-668.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7131/

20191212-112110-684.png
20191212-112154-715.png
20191212-112237-250.png
20191212-112319-124.png
20191212-113010-981.png
20191212-113011-307.png
20191212-113117-319.png
20191212-113117-504.png
20191212-113223-865.png
20191212-113224-119.png
20191212-113329-064.png
20191212-113329-288.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7131/

20191212-112037-069.png
20191212-112133-395.png
20191212-112243-047.png
20191212-112336-435.png
20191212-112804-745.png
20191212-112857-233.png
20191212-113017-159.png
20191212-113110-567.png
20191212-113635-887.png
20191212-113841-753.png
20191212-114120-170.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7131/

20191212-112037-200.png
20191212-112106-252.png
20191212-112130-891.png
20191212-112155-585.png
20191212-112219-428.png
20191212-112244-898.png
20191212-112308-851.png
20191212-112351-365.png
20191212-112939-677.png
20191212-113029-891.png
20191212-113119-135.png
20191212-113147-337.png
20191212-113210-505.png
20191212-113254-600.png
20191212-113726-772.png
20191212-113755-302.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7131/

20191212-113415-866.png
20191212-113601-243.png

@LukasHirt
Copy link
Collaborator

Can you pls take care also of checkboxes in trashbin?

@DeepDiver1975
Copy link
Member Author

Can you pls take care also of checkboxes in trashbin?

afaik they have no labels ..... will check ...

@DeepDiver1975
Copy link
Member Author

afaik they have no labels ..... will check ...

ah - no labels - but alignment was broken

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/no-checkbox-label-in-files-list branch from 24b2ee5 to 65ee1fb Compare December 12, 2019 12:43
@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7134/

20191212-125207-399.png
20191212-125302-693.png
20191212-125337-777.png
20191212-125411-176.png
20191212-125505-215.png
20191212-125538-828.png
20191212-125613-674.png
20191212-125647-988.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7134/

20191212-125139-608.png
20191212-125217-151.png
20191212-125228-993.png
20191212-125239-171.png
20191212-125249-685.png
20191212-125302-252.png
20191212-125312-253.png
20191212-125341-817.png
20191212-125642-786.png
20191212-125654-495.png
20191212-125705-915.png
20191212-125737-059.png
20191212-125746-530.png
20191212-125756-007.png
20191212-125947-125.png
20191212-130003-619.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7134/

20191212-125147-933.png
20191212-125229-198.png
20191212-125308-948.png
20191212-125349-107.png
20191212-125751-184.png
20191212-125832-670.png
20191212-125914-311.png
20191212-125956-659.png
20191212-130402-053.png
20191212-130648-563.png
20191212-130859-802.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7134/

20191212-125447-314.png
20191212-125554-060.png
20191212-125638-469.png
20191212-125724-224.png
20191212-130819-234.png
20191212-130819-617.png
20191212-130929-418.png
20191212-130929-795.png
20191212-131019-166.png
20191212-131019-657.png
20191212-131131-594.png
20191212-131131-937.png

@LukasHirt
Copy link
Collaborator

ah - no labels

Ok, I thought they have 🙈 Thanks!

@PVince81 PVince81 added the Priority:p1-urgent Consider a hotfix release with only that fix label Dec 12, 2019
@ownclouders
Copy link
Contributor

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7134/

20191212-130725-128.png
20191212-130831-872.png

@PVince81
Copy link
Contributor

restarted build...

@DeepDiver1975 DeepDiver1975 merged commit 502aa9e into master Dec 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/no-checkbox-label-in-files-list branch December 12, 2019 13:50
@ownclouders
Copy link
Contributor

💥 Acceptance tests Trashbin failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7135/

20191212-135914-600.png
20191212-135953-053.png
20191212-140031-391.png
20191212-140109-378.png
20191212-140639-824.png
20191212-140640-021.png
20191212-140719-177.png
20191212-140719-434.png
20191212-140758-607.png
20191212-140758-817.png
20191212-140856-058.png
20191212-140856-331.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests iPhone failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7135/

20191212-140124-322.png
20191212-140204-886.png
20191212-140305-471.png
20191212-140346-299.png
20191212-140427-356.png
20191212-140507-245.png
20191212-140547-529.png
20191212-140647-512.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7135/

20191212-135709-632.png
20191212-135748-666.png
20191212-135827-725.png
20191212-135928-337.png
20191212-140304-355.png
20191212-140358-122.png
20191212-140452-733.png
20191212-140546-502.png
20191212-140831-375.png
20191212-141012-890.png
20191212-141258-660.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Resharing failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/7135/

20191212-140914-665.png
20191212-141012-145.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
Priority:p1-urgent Consider a hotfix release with only that fix Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeepDiver1975 @ownclouders @LukasHirt @PVince81